Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl_ttf: fix android build in 2.0.18 & allow msvc shared since 2.20.0 #15560

Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 30, 2023

closes #15555


@SpaceIm SpaceIm changed the title sdl_ttf: fix android build in 2.0.18 & few minor fixes after 2.0.20 sdl_ttf: fix android build in 2.0.18 & few minor fixes from 2.20.0 Jan 30, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm changed the title sdl_ttf: fix android build in 2.0.18 & few minor fixes from 2.20.0 sdl_ttf: fix android build in 2.0.18 & allow msvc shared since 2.20.0 Jan 31, 2023
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 31, 2023

CMake Error at cmake_install.cmake:130 (file):
  file does not recognize sub-command COPY_FILE

I guess this issue was hidden because 2.20.1 shared was not built by default prior to this PR. I guess that's because
file(COPY_FILE has been introduced in CMake 3.21, but CMakeLists of sdl_ttf didn't update cmake min version (maybe they didn't want this bump and it was a mistake to use this feature).

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (65963b2632c39d2e5f557307ba5a788249929cd7):

  • sdl_ttf/2.0.18@:
    All packages built successfully! (All logs)

  • sdl_ttf/2.20.1@:
    All packages built successfully! (All logs)

  • sdl_ttf/2.0.15@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 5 (65963b2632c39d2e5f557307ba5a788249929cd7):

  • sdl_ttf/2.0.15@:
    Error running command conan graph info --requires sdl_ttf/2.0.15@#47c764daf505e236896263e35e0e9bd6 -f json -pr:h /home/conan/w/prod-v2_cci_PR-15560/5/1a738267-c32f-427b-9fbe-0a9f088c6c78/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2_cci_PR-15560/5/1a738267-c32f-427b-9fbe-0a9f088c6c78/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt:

    -------- Input profiles --------
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    
    -------- Computing dependency graph --------
    freetype/2.12.1: Not found in local cache, looking in remotes...
    freetype/2.12.1: Checking remote: conan-center-v2
    freetype/2.12.1: Trying with 'conan-center-v2'...
    Downloading conanfile.py
    Downloading conan_export.tgz
    Downloading conanmanifest.txt
    Decompressing conan_export.tgz
    freetype/2.12.1: Downloaded recipe revision 7e1b67634f54f38a979bbad44fd09a2c
    libpng/1.6.39: Not found in local cache, looking in remotes...
    libpng/1.6.39: Checking remote: conan-center-v2
    libpng/1.6.39: Trying with 'conan-center-v2'...
    Downloading conanfile.py
    Downloading conan_export.tgz
    Downloading conanmanifest.txt
    Decompressing conan_export.tgz
    libpng/1.6.39: Downloaded recipe revision 7927e8ce5b2576a6ea497c6ca70e9751
    zlib/1.2.13: Not found in local cache, looking in remotes...
    zlib/1.2.13: Checking remote: conan-center-v2
    zlib/1.2.13: Trying with 'conan-center-v2'...
    Downloading conan_export.tgz
    Downloading conanfile.py
    Downloading conanmanifest.txt
    Decompressing conan_export.tgz
    zlib/1.2.13: Downloaded recipe revision 13c96f538b52e1600c40b88994de240f
    bzip2/1.0.8: Not found in local cache, looking in remotes...
    bzip2/1.0.8: Checking remote: conan-center-v2
    bzip2/1.0.8: Trying with 'conan-center-v2'...
    Downloading conanfile.py
    Downloading conan_export.tgz
    Downloading conanmanifest.txt
    Decompressing conan_export.tgz
    bzip2/1.0.8: Downloaded recipe revision 464be69744fa6d48ed01928cfe470008
    brotli/1.0.9: Not found in local cache, looking in remotes...
    brotli/1.0.9: Checking remote: conan-center-v2
    brotli/1.0.9: Trying with 'conan-center-v2'...
    Downloading conanmanifest.txt
    Downloading conanfile.py
    Downloading conan_export.tgz
    Decompressing conan_export.tgz
    brotli/1.0.9: Downloaded recipe revision 4bfbb302b87df342ccd6a2b5fdad307a
    sdl/2.26.1: Not found in local cache, looking in remotes...
    sdl/2.26.1: Checking remote: conan-center-v2
    Graph root
        virtual
    Requirements
        brotli/1.0.9#4bfbb302b87df342ccd6a2b5fdad307a - Downloaded (conan-center-v2)
        bzip2/1.0.8#464be69744fa6d48ed01928cfe470008 - Downloaded (conan-center-v2)
        freetype/2.12.1#7e1b67634f54f38a979bbad44fd09a2c - Downloaded (conan-center-v2)
        libpng/1.6.39#7927e8ce5b2576a6ea497c6ca70e9751 - Downloaded (conan-center-v2)
        sdl_ttf/2.0.15#47c764daf505e236896263e35e0e9bd6 - Cache
        zlib/1.2.13#13c96f538b52e1600c40b88994de240f - Downloaded (conan-center-v2)
    Graph error
        Package 'sdl/2.26.1' not resolved: Unable to find 'sdl/2.26.1' in remotes
    ERROR: Package 'sdl/2.26.1' not resolved: Unable to find 'sdl/2.26.1' in remotes
    
  • sdl_ttf/2.20.1@:
    Error running command conan graph info --requires sdl_ttf/2.20.1@#4b60201c494ba6d90ab402fd655c2278 -f json -pr:h /home/conan/w/prod-v2_cci_PR-15560/5/1b3ac7e1-131a-41e4-aa23-784923d86be2/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2_cci_PR-15560/5/1b3ac7e1-131a-41e4-aa23-784923d86be2/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt:

    -------- Input profiles --------
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    
    -------- Computing dependency graph --------
    freetype/2.12.1: Not found in local cache, looking in remotes...
    freetype/2.12.1: Checking remote: conan-center-v2
    freetype/2.12.1: Trying with 'conan-center-v2'...
    Downloading conanfile.py
    Downloading conan_export.tgz
    Downloading conanmanifest.txt
    Decompressing conan_export.tgz
    freetype/2.12.1: Downloaded recipe revision 7e1b67634f54f38a979bbad44fd09a2c
    libpng/1.6.39: Not found in local cache, looking in remotes...
    libpng/1.6.39: Checking remote: conan-center-v2
    libpng/1.6.39: Trying with 'conan-center-v2'...
    Downloading conanfile.py
    Downloading conanmanifest.txt
    Downloading conan_export.tgz
    Decompressing conan_export.tgz
    libpng/1.6.39: Downloaded recipe revision 7927e8ce5b2576a6ea497c6ca70e9751
    zlib/1.2.13: Not found in local cache, looking in remotes...
    zlib/1.2.13: Checking remote: conan-center-v2
    zlib/1.2.13: Trying with 'conan-center-v2'...
    Downloading conan_export.tgz
    Downloading conanfile.py
    Downloading conanmanifest.txt
    Decompressing conan_export.tgz
    zlib/1.2.13: Downloaded recipe revision 13c96f538b52e1600c40b88994de240f
    bzip2/1.0.8: Not found in local cache, looking in remotes...
    bzip2/1.0.8: Checking remote: conan-center-v2
    bzip2/1.0.8: Trying with 'conan-center-v2'...
    Downloading conanfile.py
    Downloading conan_export.tgz
    Downloading conanmanifest.txt
    Decompressing conan_export.tgz
    bzip2/1.0.8: Downloaded recipe revision 464be69744fa6d48ed01928cfe470008
    brotli/1.0.9: Not found in local cache, looking in remotes...
    brotli/1.0.9: Checking remote: conan-center-v2
    brotli/1.0.9: Trying with 'conan-center-v2'...
    Downloading conan_export.tgz
    Downloading conanfile.py
    Downloading conanmanifest.txt
    Decompressing conan_export.tgz
    brotli/1.0.9: Downloaded recipe revision 4bfbb302b87df342ccd6a2b5fdad307a
    sdl/2.26.1: Not found in local cache, looking in remotes...
    sdl/2.26.1: Checking remote: conan-center-v2
    Graph root
        virtual
    Requirements
        brotli/1.0.9#4bfbb302b87df342ccd6a2b5fdad307a - Downloaded (conan-center-v2)
        bzip2/1.0.8#464be69744fa6d48ed01928cfe470008 - Downloaded (conan-center-v2)
        freetype/2.12.1#7e1b67634f54f38a979bbad44fd09a2c - Downloaded (conan-center-v2)
        libpng/1.6.39#7927e8ce5b2576a6ea497c6ca70e9751 - Downloaded (conan-center-v2)
        sdl_ttf/2.20.1#4b60201c494ba6d90ab402fd655c2278 - Cache
        zlib/1.2.13#13c96f538b52e1600c40b88994de240f - Downloaded (conan-center-v2)
    Graph error
        Package 'sdl/2.26.1' not resolved: Unable to find 'sdl/2.26.1' in remotes
    ERROR: Package 'sdl/2.26.1' not resolved: Unable to find 'sdl/2.26.1' in remotes
    
  • sdl_ttf/2.0.18@:
    Error running command conan graph info --requires sdl_ttf/2.0.18@#b4974bc6667e7ef139d17fd55b048f59 -f json -pr:h /home/conan/w/prod-v2_cci_PR-15560/5/d7c8260e-e944-4f4f-bf92-18b4990ef317/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2_cci_PR-15560/5/d7c8260e-e944-4f4f-bf92-18b4990ef317/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt:

    -------- Input profiles --------
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    
    -------- Computing dependency graph --------
    freetype/2.12.1: Not found in local cache, looking in remotes...
    freetype/2.12.1: Checking remote: conan-center-v2
    freetype/2.12.1: Trying with 'conan-center-v2'...
    Downloading conanfile.py
    Downloading conanmanifest.txt
    Downloading conan_export.tgz
    Decompressing conan_export.tgz
    freetype/2.12.1: Downloaded recipe revision 7e1b67634f54f38a979bbad44fd09a2c
    libpng/1.6.39: Not found in local cache, looking in remotes...
    libpng/1.6.39: Checking remote: conan-center-v2
    libpng/1.6.39: Trying with 'conan-center-v2'...
    Downloading conanfile.py
    Downloading conanmanifest.txt
    Downloading conan_export.tgz
    Decompressing conan_export.tgz
    libpng/1.6.39: Downloaded recipe revision 7927e8ce5b2576a6ea497c6ca70e9751
    zlib/1.2.13: Not found in local cache, looking in remotes...
    zlib/1.2.13: Checking remote: conan-center-v2
    zlib/1.2.13: Trying with 'conan-center-v2'...
    Downloading conan_export.tgz
    Downloading conanfile.py
    Downloading conanmanifest.txt
    Decompressing conan_export.tgz
    zlib/1.2.13: Downloaded recipe revision 13c96f538b52e1600c40b88994de240f
    bzip2/1.0.8: Not found in local cache, looking in remotes...
    bzip2/1.0.8: Checking remote: conan-center-v2
    bzip2/1.0.8: Trying with 'conan-center-v2'...
    Downloading conanmanifest.txt
    Downloading conanfile.py
    Downloading conan_export.tgz
    Decompressing conan_export.tgz
    bzip2/1.0.8: Downloaded recipe revision 464be69744fa6d48ed01928cfe470008
    brotli/1.0.9: Not found in local cache, looking in remotes...
    brotli/1.0.9: Checking remote: conan-center-v2
    brotli/1.0.9: Trying with 'conan-center-v2'...
    Downloading conanmanifest.txt
    Downloading conan_export.tgz
    Downloading conanfile.py
    Decompressing conan_export.tgz
    brotli/1.0.9: Downloaded recipe revision 4bfbb302b87df342ccd6a2b5fdad307a
    sdl/2.26.1: Not found in local cache, looking in remotes...
    sdl/2.26.1: Checking remote: conan-center-v2
    Graph root
        virtual
    Requirements
        brotli/1.0.9#4bfbb302b87df342ccd6a2b5fdad307a - Downloaded (conan-center-v2)
        bzip2/1.0.8#464be69744fa6d48ed01928cfe470008 - Downloaded (conan-center-v2)
        freetype/2.12.1#7e1b67634f54f38a979bbad44fd09a2c - Downloaded (conan-center-v2)
        libpng/1.6.39#7927e8ce5b2576a6ea497c6ca70e9751 - Downloaded (conan-center-v2)
        sdl_ttf/2.0.18#b4974bc6667e7ef139d17fd55b048f59 - Cache
        zlib/1.2.13#13c96f538b52e1600c40b88994de240f - Downloaded (conan-center-v2)
    Graph error
        Package 'sdl/2.26.1' not resolved: Unable to find 'sdl/2.26.1' in remotes
    ERROR: Package 'sdl/2.26.1' not resolved: Unable to find 'sdl/2.26.1' in remotes
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Hooks produced the following warnings for commit 65963b2
sdl_ttf/2.0.18
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_ttf.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_ttf.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_ttf.dylib' links to system library 'CoreGraphics' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_ttf.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
sdl_ttf/2.0.15
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_ttf.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_ttf.dylib' links to system library 'CoreGraphics' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_ttf.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_ttf.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 8101c26 into conan-io:master Feb 2, 2023
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
…ared since 2.20.0

* fix Android build in 2.0.18

* few fixes

* allow sdl_ttf shared with msvc since 2.20.0

* download official tarball of 2.0.15

* Disable useless .pc file install in 2.20.1 to avoid relying on CMake 3.21 features

* remove debug postfix
sabelka pushed a commit to sabelka/conan-center-index that referenced this pull request Feb 12, 2023
…ared since 2.20.0

* fix Android build in 2.0.18

* few fixes

* allow sdl_ttf shared with msvc since 2.20.0

* download official tarball of 2.0.15

* Disable useless .pc file install in 2.20.1 to avoid relying on CMake 3.21 features

* remove debug postfix
@SpaceIm SpaceIm deleted the fix/sdl-ttf-2.0.18-android branch April 14, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] sdl_ttf/2.0.18: tries to use PkgConfig and harfbuzz from system
4 participants