-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdl_ttf: fix android build in 2.0.18 & allow msvc shared since 2.20.0 #15560
sdl_ttf: fix android build in 2.0.18 & allow msvc shared since 2.20.0 #15560
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I guess this issue was hidden because 2.20.1 shared was not built by default prior to this PR. I guess that's because |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit 65963b2sdl_ttf/2.0.18
sdl_ttf/2.0.15
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ared since 2.20.0 * fix Android build in 2.0.18 * few fixes * allow sdl_ttf shared with msvc since 2.20.0 * download official tarball of 2.0.15 * Disable useless .pc file install in 2.20.1 to avoid relying on CMake 3.21 features * remove debug postfix
…ared since 2.20.0 * fix Android build in 2.0.18 * few fixes * allow sdl_ttf shared with msvc since 2.20.0 * download official tarball of 2.0.15 * Disable useless .pc file install in 2.20.1 to avoid relying on CMake 3.21 features * remove debug postfix
closes #15555