Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openal: deprecate in favor of openal-soft + download official tarballs + modernize more #15590

Merged
merged 4 commits into from
Feb 10, 2023
Merged

openal: deprecate in favor of openal-soft + download official tarballs + modernize more #15590

merged 4 commits into from
Feb 10, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 31, 2023 •
edited
Loading

see #15716

@SpaceIm SpaceIm closed this Jan 31, 2023
@SpaceIm SpaceIm reopened this Jan 31, 2023
@github-actions github-actions bot mentioned this pull request Jan 31, 2023
Open
jwillikers
jwillikers previously approved these changes Jan 31, 2023
View reviewed changes
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm closed this Feb 1, 2023
@SpaceIm SpaceIm reopened this Feb 1, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
jwillikers
jwillikers previously approved these changes Feb 2, 2023
View reviewed changes
@prince-chrismc prince-chrismc mentioned this pull request Feb 2, 2023
Merged
1 task
uilianries
uilianries previously approved these changes Feb 3, 2023
View reviewed changes
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Feb 3, 2023

😩

@SpaceIm SpaceIm closed this Feb 3, 2023
@SpaceIm SpaceIm reopened this Feb 3, 2023
@SpaceIm SpaceIm closed this Feb 3, 2023
@SpaceIm SpaceIm reopened this Feb 3, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm closed this Feb 4, 2023
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Feb 4, 2023

16 hours to build & run test package, seriously?

@SpaceIm SpaceIm reopened this Feb 4, 2023
@SpaceIm SpaceIm dismissed stale reviews from uilianries and jwillikers via 542b07e February 4, 2023 12:53
@SpaceIm SpaceIm changed the title openal: download official tarballs + modernize more openal: deprecate in favor of openal-soft + download official tarballs + modernize more Feb 4, 2023
@SpaceIm SpaceIm mentioned this pull request Feb 4, 2023
Merged
3 tasks
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Feb 4, 2023 •
edited
Loading

I've added an extra modification: deprecation of this recipe in favor of openal-soft recipe (#15716). It should have been done long time ago.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (542b07ece7b5670db4dbdcfc594d07d34d6e785a):

  • openal/1.22.2@:
    All packages built successfully! (All logs)

  • openal/1.21.1@:
    All packages built successfully! (All logs)

  • openal/1.21.0@:
    All packages built successfully! (All logs)

  • openal/1.20.1@:
    All packages built successfully! (All logs)

  • openal/1.19.1@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 8 (542b07ece7b5670db4dbdcfc594d07d34d6e785a):

An unexpected error happened and has been reported. Help is on its way! 🏇

@prince-chrismc
Copy link
Contributor

image

@conan-center-bot conan-center-bot merged commit e632033 into conan-io:master Feb 10, 2023
@SpaceIm SpaceIm deleted the openal-official-tarball branch February 10, 2023 09:45
sabelka pushed a commit to sabelka/conan-center-index that referenced this pull request Feb 12, 2023
@SpaceIm @sabelka
(conan-io#15590) openal: deprecate in favor of openal-soft + download…
88110d9 
… official tarballs + modernize more

* modernize more

* download official tarballs

* fix patch type

* deprecate in favor of openal-soft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries uilianries left review comments

Assignees
No one assigned
Labels
checksum_mismatch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SpaceIm @conan-center-bot @prince-chrismc @uilianries @jwillikers