Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvpx: add support for msvc17 193 #15607

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

paulharris
Copy link
Contributor

A simple patch to add support for MSVC17

A quick and simple follow-up to #13799

@@ -160,7 +160,7 @@ def _execute_configure(self):
elif is_msvc(self):
vc_version = str(self.settings.compiler.version)
if Version(self.settings.compiler.version) > "100": # New msvc compiler to triplet used in configure script for vpx
vc_version = {"190": "14", "191": "15", "192": "16"}[vc_version]
vc_version = {"190": "14", "191": "15", "192": "16", "193": "17"}[vc_version]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vc_version = {"190": "14", "191": "15", "192": "16", "193": "17"}[vc_version]
vc_version = {"170": "11", "180": "12", "190": "14", "191": "15", "192": "16", "193": "17"}[vc_version]

Copy link
Contributor

@SpaceIm SpaceIm Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove this ConanInvalidConfiguration you have added in last PR at the end of this branching? ConanInvalidConfiguration should only be called in validate() and there is already a logic in validate() checking that we cannot use other compilers not managed be current logic in _execute_configure().
It's something I've removed long time ago in #6405, I don't understand why this broken logic has been restored. Raise a ConanException if you want, but it's just defensive programming since by recipe design in validate(), conan can't go into this branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok good point :)

@@ -160,7 +160,7 @@ def _execute_configure(self):
elif is_msvc(self):
vc_version = str(self.settings.compiler.version)
if Version(self.settings.compiler.version) > "100": # New msvc compiler to triplet used in configure script for vpx
Copy link
Contributor

@SpaceIm SpaceIm Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean? This if is useless, you already know that you are in the compiler=msvc case because compiler == "Visual Studio" has been tested first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True!

@conan-center-bot

This comment has been minimized.

paulharris and others added 2 commits February 2, 2023 11:13
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (540cc2107ed6586a09ce7beb73baabac87888905):

  • libvpx/1.11.0@:
    All packages built successfully! (All logs)

  • libvpx/1.10.0@:
    All packages built successfully! (All logs)

  • libvpx/1.9.0@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 3 (540cc2107ed6586a09ce7beb73baabac87888905):

  • libvpx/1.10.0@:
    Didn't run or was cancelled before finishing

  • libvpx/1.11.0@:
    CI failed to create some packages (All logs)

    Logs for packageID 249071e58372dd7711267ba636bb001debd2e04e:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    [...]
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    [conf]
    tools.system.package_manager:mode=install
    tools.system.package_manager:sudo=True
    
    
    -------- Computing dependency graph --------
    yasm/1.3.0: Not found in local cache, looking in remotes...
    yasm/1.3.0: Checking remote: conan-center-v2
    yasm/1.3.0: Trying with 'conan-center-v2'...
    Downloading conanmanifest.txt
    Downloading conan_export.tgz
    Downloading conanfile.py
    Decompressing conan_export.tgz
    yasm/1.3.0: Downloaded recipe revision 2a3d4e934b903c33d380b47bdf7f45be
    Graph root
        virtual
    Requirements
        libvpx/1.11.0#bf2bd71f456902f70e4cda4056759cce - Cache
    Build requirements
        yasm/1.3.0#2a3d4e934b903c33d380b47bdf7f45be - Downloaded (conan-center-v2)
    
    -------- Computing necessary packages --------
    libvpx/1.11.0: Forced build from source
    Requirements
        libvpx/1.11.0#bf2bd71f456902f70e4cda4056759cce:249071e58372dd7711267ba636bb001debd2e04e - Build
    Build requirements
        yasm/1.3.0#2a3d4e934b903c33d380b47bdf7f45be:3593751651824fb813502c69c971267624ced41a - Missing
    
    -------- Installing packages --------
    
    -------- Installing (downloading, building) binaries... --------
    ERROR: Missing binary: yasm/1.3.0:3593751651824fb813502c69c971267624ced41a
    
    yasm/1.3.0: WARN: Can't find a 'yasm/1.3.0' package binary '3593751651824fb813502c69c971267624ced41a' for the configuration:
    [settings]
    arch=x86_64
    build_type=Release
    os=Linux
    
    ERROR: Missing prebuilt package for 'yasm/1.3.0'
    Use 'conan list packages yasm/1.3.0 --format=html -r=remote > table.html' and open the table.html file to see available packages
    Or try to build locally from sources with '--build=yasm/1.3.0'
    
    More Info at 'https://docs.conan.io/en/latest/faq/troubleshooting.html#error-missing-prebuilt-package'
    
  • libvpx/1.9.0@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot conan-center-bot merged commit da5458d into conan-io:master Feb 3, 2023
@paulharris paulharris deleted the libvpx-msvc-193 branch February 3, 2023 03:08
sabelka pushed a commit to sabelka/conan-center-index that referenced this pull request Feb 12, 2023
* libvpx: add support for msvc17 193

* Update recipes/libvpx/all/conanfile.py

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* Remove useless tests - already checked in validate()

---------

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants