Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpprestsdk: add package_type + bump boost & openssl + remove package id boost minor mode #17096

Merged
merged 3 commits into from
Jun 21, 2023
Merged

cpprestsdk: add package_type + bump boost & openssl + remove package id boost minor mode #17096

merged 3 commits into from
Jun 21, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 18, 2023

  • bump boost & openssl
  • follow import conventions of conan API
  • add package_type
  • remove boost minor mode (useless in conan v2 and problematic for v1 pipeline)

@SpaceIm
bump boost & openssl
310a1f6
@SpaceIm
few changes
60b282b 
- follow import conventions of conan API
- add package_type
- remove boost minor mode
@prince-chrismc prince-chrismc mentioned this pull request Apr 18, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 60b282b
cpprestsdk/2.10.18 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcpprest.so' links to system library 'm' but it is not in cpp_info.system_libs.
cpprestsdk/2.10.15 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcpprest.so' links to system library 'm' but it is not in cpp_info.system_libs.
cpprestsdk/2.10.17 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcpprest.so' links to system library 'm' but it is not in cpp_info.system_libs.
cpprestsdk/2.10.16 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcpprest.so' links to system library 'm' but it is not in cpp_info.system_libs.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Apr 18, 2023

waiting for #17095

@SpaceIm SpaceIm marked this pull request as draft April 18, 2023 17:37
@SpaceIm SpaceIm mentioned this pull request Apr 19, 2023
Closed
3 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 93233d2
cpprestsdk/2.10.18 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcpprest.so' links to system library 'm' but it is not in cpp_info.system_libs.
cpprestsdk/2.10.15 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcpprest.so' links to system library 'm' but it is not in cpp_info.system_libs.
cpprestsdk/2.10.17 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcpprest.so' links to system library 'm' but it is not in cpp_info.system_libs.
cpprestsdk/2.10.16 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcpprest.so' links to system library 'm' but it is not in cpp_info.system_libs.

@SpaceIm SpaceIm closed this Apr 28, 2023
@SpaceIm SpaceIm reopened this Apr 28, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm closed this Apr 28, 2023
@SpaceIm SpaceIm reopened this Apr 28, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm marked this pull request as ready for review April 29, 2023 08:22
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm closed this May 6, 2023
@SpaceIm SpaceIm reopened this May 6, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (93233d20ed3a2058b381b32bf4ebd8897f107d98):

  • cpprestsdk/2.10.18@:
    All packages built successfully! (All logs)

  • cpprestsdk/2.10.17@:
    All packages built successfully! (All logs)

  • cpprestsdk/2.10.16@:
    All packages built successfully! (All logs)

  • cpprestsdk/2.10.15@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 5 (93233d20ed3a2058b381b32bf4ebd8897f107d98):

  • cpprestsdk/2.10.18@:
    All packages built successfully! (All logs)

  • cpprestsdk/2.10.17@:
    All packages built successfully! (All logs)

  • cpprestsdk/2.10.16@:
    All packages built successfully! (All logs)

  • cpprestsdk/2.10.15@:
    All packages built successfully! (All logs)

@CLAassistant
Copy link

CLAassistant commented May 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@stale
Copy link

stale bot commented Jun 18, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 18, 2023
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jun 21, 2023

@ericLemanissier @jwillikers @prince-chrismc @RubenRBS @uilianries could you review this one please before being closed by ci bot? It's green for almost 2 months.

@stale stale bot removed the stale label Jun 21, 2023
uilianries
uilianries reviewed Jun 21, 2023
View reviewed changes
recipes/cpprestsdk/all/conanfile.py
def requirements(self):
self.requires("boost/1.80.0")
self.requires("openssl/1.1.1s")
self.requires("boost/1.81.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.requires("boost/1.81.0")
self.requires("boost/1.82.0")

uilianries
uilianries approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AbrilRBS
AbrilRBS approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, sometimes some PRs fall thru the cracks. We're actively working on improving our processes to ensure this happens less often, so hopefully you'll be seeing less cases like this one :)

@conan-center-bot conan-center-bot merged commit fb6f781 into conan-io:master Jun 21, 2023
@SpaceIm SpaceIm deleted the cpprestsdk-bump-deps branch June 21, 2023 13:07
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
@SpaceIm @pezy
(conan-io#17096) cpprestsdk: add package_type + bump boost & openssl …
3722a48 
…+ remove package id boost minor mode

* bump boost & openssl

* few changes

- follow import conventions of conan API
- add package_type
- remove boost minor mode

* use version range for openssl
@garethsb
Copy link
Contributor

remove boost minor mode (useless in conan v2 and problematic for v1 pipeline)

To the contrary, as discussed for a long time in #8856, minor mode is required in conan v1, and removing this has regressed this recipe.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Aug 10, 2023

Actually, it was a request of CCI maintainers to remove minor_mode in all recipes (I can't remember original post).

@garethsb garethsb mentioned this pull request Oct 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@uilianries uilianries uilianries approved these changes

@ericLemanissier ericLemanissier ericLemanissier approved these changes

@jcar87 jcar87 Awaiting requested review from jcar87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SpaceIm @conan-center-bot @CLAassistant @garethsb @ericLemanissier @uilianries @AbrilRBS