-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ncurses] Add conan 2.0 compatibility #17805
Conversation
missing comma added
+ split method with too many local variables and too many statements + replace f-string without interpolated variables with normal string
ac20eee
to
8e33b8d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying ncurses/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
@madebr I resurrected this PR (originally authored in #16780) in the hope of resolving its issues and getting ncurses integrated for conan 2.0. It looks to already be in a really good state, but it's currently failing on shared MSVC builds (see the error in CI) - it's failing to build the terminfo database. There appears to be very little in the way of error messages or logs for me to latch onto here, so I'm having a hard time identifying what the problem actually is. To make matters worse, I'm also having a hard time getting the 1.x variant to work, which would have helped me identify the difference between the two recipes to close the gap and hopefully resolve the issue. I noticed that you were responsible for facilitating the upstreaming of the MSVC compatibility a few years ago in mirror/ncurses#1 - wondering if you're able to point me in the right direction here? Any ideas what might be breaking? Any help you can provide is appreciated. |
Comparing the failed log with the output of these logs, the only difference I see is conan v2 adding |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 3 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Sorry, the system is under maintenance and it doesn't accept builds right now. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
bump |
Bump |
This is a continuation of previous attempts to add conan 2 compatibility in #16780 and #15062