-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
b2: update 'standard' recipe to match the newer 'portable' #18089
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/b2//'. 👋 @grafikrobot you might be interested. 😉 |
I detected other pull requests that are modifying b2/portable recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT the changes you made are:
- A bunch of style only changes. Why?
- Adding compiler and build_type to settings. Why?
- Using option_descriptions. Great!
- Clearing of some cpp_info vars. Great!
- Putting the old and new build code into one recipe by adding the _build_non_portable function and version check. Why?
I'm wondering why you did (1) as it just makes the history harder to follow.
I'm wondering why you did (2). As mentioned in the other comment.. This goes against an intentional choice.
Last, (5). I really don't understand the goal of this PR. Why complicate the new build and install mode with the old mode? Is there some use case or problem you are trying to fix?
Sorry, these were incidental and not really relevant. Reverted them.
Added these to match the current recommendation to always list all values and then remove the irrelevant settings in
The intention behind this PR was (1) to eliminate unnecessary dead code in the repo by updating the I originally did not intend to modify the Anyway, I reverted the merge of the |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
Conan v1 pipeline ❌Sorry, the system is under maintenance and it doesn't accept builds right now. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Sorry, the system is under maintenance and it doesn't accept builds right now. |
Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again. |
TODO
Empty package