feat(qt): improve qt test_package and fix qt libs dependencies #18650

ledocc · 2023-07-19T10:27:15Z

Qt have many libs,
each one should be tested to check if link informations is correctly defined in conan recipe with this link test, some libs dependencies have be fixed

Specify library name and version: qt/5.x.x

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

Qt have many libs, each one should be tested to check if link informations is correctly defined in conan recipe with this link test, some libs dependencies have be fixed

CLAassistant · 2023-07-19T10:27:22Z

All committers have signed the CLA.

github-actions · 2023-07-19T10:28:22Z

🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'.

👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉

ghost · 2023-07-19T10:30:34Z

I detected other pull requests that are modifying qt/5.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

ericLemanissier

That's a massive piece of work, thanks !
I'm not sure the test recipe covering all modules is compatible with CCI policy though :/

ericLemanissier · 2023-07-19T11:04:32Z

recipes/qt/5.x.x/conanfile.py

-                if self.options.get_safe("with_x11", False):
-                    gui_reqs.append("xorg::xorg")


xorg has to be referenced as a requirement of at least one component. Why do You think it's not needed here, wereas qt checks for these libraries during GUI module configuration https://github.com/qt/qtbase/blob/v5.15.10-lts-lgpl/src/gui/configure.json#L556 ?

This dependencies is the first that I try to remove because I know that QtGUI is platform agnostic, and platform dependencies is in platforms plugins. To do this, I add test for QtGui module in test_package. If test can link and run, this mean that dependencies list defined in conanfile is exhaustive.

Now, I have a test to confirm that Xorg is not in QtGUI,

To be precise, xcb_qpa_lib is link against xcb, and platforms/xcb plugins (and platforms/xcb/gl_integrations) is link against xcb_qpa_lib
https://github.com/qt/qtbase/blob/v5.15.10-lts-lgpl/src/plugins/platforms/xcb/xcb_qpa_lib.pro#L94
https://github.com/qt/qtbase/blob/v5.15.10-lts-lgpl/src/plugins/platforms/xcb/xcb-plugin.pro#L3
https://github.com/qt/qtbase/blob/v5.15.10-lts-lgpl/src/plugins/platforms/xcb/gl_integrations/gl_integrations_plugin_base.pri#L1

xorg is referenced by XcbQpa component

ericLemanissier · 2023-07-19T11:05:55Z

recipes/qt/5.x.x/conanfile.py

+                widget_reqs = ["Gui"]
+                if self.options.with_freetype:
+                    widget_reqs.append("freetype::freetype")
+                _create_module("Widgets", widget_reqs)


What makes you think freetype is a requirements of Widgets instead of GUI ? freetype is checked by qt in GUI but not in Widgets

Freetype is hidden in fontdatabase, plugins.
Their also are reference in platforms/xcb and platforms/minimal plugin, but I don't know why
The only reference to freetype in .pro/.pri for linking with it are:
https://github.com/qt/qtbase/blob/v5.15.10-lts-lgpl/src/platformsupport/fontdatabases/freetype/freetype.pri#L9
https://github.com/qt/qtbase/blob/v5.15.10-lts-lgpl/src/plugins/platforms/xcb/nativepainting/nativepainting.pri#L3
https://github.com/qt/qtbase/blob/v5.15.10-lts-lgpl/src/plugins/platforms/minimal/minimal.pro#L17

I will also remove it from QtWidget

…lready in generate() method

recipes/qt/5.x.x/test_package/conanfile.py

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

…able

conan-center-bot · 2023-08-08T02:49:00Z

Conan v1 pipeline ❌

Failure in build 3 (a98ea8a4eb45fe2ced2d77e575f2c3d18fdeb069):

qt/5.15.7@:
CI failed to create some packages (All logs)

Logs for packageID 8b45f593ce88d21827e7621d89a2153124bd7d49:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=5
os=Linux
[options]
qt:shared=False

[...]
-- Found: /home/conan/w/prod-v1/BuildSingleReference/.conan/data/icu/73.2/_/_/package/980215d0c67ac9b4bcb6c34a43716e6531af0d43/lib/libicuuc.a
-- Library icui18n found /home/conan/w/prod-v1/BuildSingleReference/.conan/data/icu/73.2/_/_/package/980215d0c67ac9b4bcb6c34a43716e6531af0d43/lib/libicui18n.a
-- Found: /home/conan/w/prod-v1/BuildSingleReference/.conan/data/icu/73.2/_/_/package/980215d0c67ac9b4bcb6c34a43716e6531af0d43/lib/libicui18n.a
-- Library icutu found /home/conan/w/prod-v1/BuildSingleReference/.conan/data/icu/73.2/_/_/package/980215d0c67ac9b4bcb6c34a43716e6531af0d43/lib/libicutu.a
-- Found: /home/conan/w/prod-v1/BuildSingleReference/.conan/data/icu/73.2/_/_/package/980215d0c67ac9b4bcb6c34a43716e6531af0d43/lib/libicutu.a
-- Library icutest found /home/conan/w/prod-v1/BuildSingleReference/.conan/data/icu/73.2/_/_/package/980215d0c67ac9b4bcb6c34a43716e6531af0d43/lib/libicutest.a
-- Found: /home/conan/w/prod-v1/BuildSingleReference/.conan/data/icu/73.2/_/_/package/980215d0c67ac9b4bcb6c34a43716e6531af0d43/lib/libicutest.a
-- Library icuio found /home/conan/w/prod-v1/BuildSingleReference/.conan/data/icu/73.2/_/_/package/980215d0c67ac9b4bcb6c34a43716e6531af0d43/lib/libicuio.a
-- Found: /home/conan/w/prod-v1/BuildSingleReference/.conan/data/icu/73.2/_/_/package/980215d0c67ac9b4bcb6c34a43716e6531af0d43/lib/libicuio.a
-- Library zstd found /home/conan/w/prod-v1/BuildSingleReference/.conan/data/zstd/1.5.5/_/_/package/ff7e1eda45846fc95249ac3e0c50da0e296272b3/lib/libzstd.a
-- Found: /home/conan/w/prod-v1/BuildSingleReference/.conan/data/zstd/1.5.5/_/_/package/ff7e1eda45846fc95249ac3e0c50da0e296272b3/lib/libzstd.a
-- Library zstd found /home/conan/w/prod-v1/BuildSingleReference/.conan/data/zstd/1.5.5/_/_/package/ff7e1eda45846fc95249ac3e0c50da0e296272b3/lib/libzstd.a
-- Found: /home/conan/w/prod-v1/BuildSingleReference/.conan/data/zstd/1.5.5/_/_/package/ff7e1eda45846fc95249ac3e0c50da0e296272b3/lib/libzstd.a
-- Configuring done
-- Generating done
CMake Error at /home/conan/w/prod-v1/BuildSingleReference/cci-8f629288/recipes/qt/5.x.x/test_package/target.cmake:4 (add_executable):
  Cannot find source file:

    test_package-Core.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
  .hpp .hxx .in .txx
Call Stack (most recent call first):
  /home/conan/w/prod-v1/BuildSingleReference/cci-8f629288/recipes/qt/5.x.x/test_package/target.cmake:35 (add_qt_executable)
  /home/conan/w/prod-v1/BuildSingleReference/cci-8f629288/recipes/qt/5.x.x/test_package/target.cmake:50 (add_qt_exe)
  CMakeLists.txt:14 (include)


CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_INSTALL_BINDIR
    CMAKE_INSTALL_DATAROOTDIR
    CMAKE_INSTALL_INCLUDEDIR
    CMAKE_INSTALL_LIBDIR
    CMAKE_INSTALL_LIBEXECDIR
    CMAKE_INSTALL_OLDINCLUDEDIR
    CMAKE_INSTALL_SBINDIR
    CONAN_COMPILER_VERSION
    CONAN_EXPORTED
    CONAN_IN_LOCAL_CACHE


CMake Generate step failed.  Build files cannot be regenerated correctly.
ERROR: qt/5.15.7 (test package): Error in build() method, line 118
	self._build_with_cmake_find_package_multi()
while calling '_build_with_cmake_find_package_multi', line 112
	cmake.configure()
	ConanException: Error 1 while executing cd '/home/conan/w/prod-v1/BuildSingleReference/cci-8f629288/recipes/qt/5.x.x/test_v1_package/build/0bd11cf99b3d466cd4120aa3c3fccf3ce0fc35bc' && cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="OFF" -DCONAN_COMPILER="gcc" -DCONAN_COMPILER_VERSION="5" -DCONAN_CXX_FLAGS="-m64" -DCONAN_SHARED_LINKER_FLAGS="-m64" -DCONAN_C_FLAGS="-m64" -DCMAKE_CXX_FLAGS="-m64" -DCMAKE_SHARED_LINKER_FLAGS="-m64" -DCMAKE_C_FLAGS="-m64" -DCONAN_LIBCXX="libstdc++11" -DCMAKE_INSTALL_PREFIX="/home/conan/w/prod-v1/BuildSingleReference/cci-8f629288/recipes/qt/5.x.x/test_v1_package/build/0bd11cf99b3d466cd4120aa3c3fccf3ce0fc35bc/package" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCMAKE_PREFIX_PATH="/home/conan/w/prod-v1/BuildSingleReference/cci-8f629288/recipes/qt/5.x.x/test_v1_package/build/0bd11cf99b3d466cd4120aa3c3fccf3ce0fc35bc" -DCMAKE_MODULE_PATH="/home/conan/w/prod-v1/BuildSingleReference/cci-8f629288/recipes/qt/5.x.x/test_v1_package/build/0bd11cf99b3d466cd4120aa3c3fccf3ce0fc35bc" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -Wno-dev '/home/conan/w/prod-v1/BuildSingleReference/cci-8f629288/recipes/qt/5.x.x/test_v1_package'

qt/5.15.9@:
Didn't run or was cancelled before finishing
qt/5.15.10@:
Didn't run or was cancelled before finishing
qt/5.15.8@:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

stale · 2023-09-17T16:47:00Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2024-04-22T06:36:08Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

leha-bot · 2024-04-24T20:59:48Z

@ledocc hello, sorry for mentioning, may you continue work on this PR? It looks like that it's almost complete and looks great for early detecting some nasty link errors

ledocc · 2024-04-29T18:55:55Z

@ledocc hello, sorry for mentioning, may you continue work on this PR? It looks like that it's almost complete and looks great for early detecting some nasty link errors

Hi @leha-bot, no problem for mentioning me.

I no longer work on this PR this comment. But I continue on my side to fix qt dependencies.

I also think a test that link and run for each library is require in conan's test_package. But seem that's not CCI policy.

feat(qt): improve qt test_package and fix qt libs dependencies

03d58ae

Qt have many libs, each one should be tested to check if link informations is correctly defined in conan recipe with this link test, some libs dependencies have be fixed

This was referenced Jul 19, 2023

[service] Potentially conflicting recipes #3571

Closed

qt: remove opengl dependency for android #18545

Closed

Qt5: use layout #18376

Closed

prince-chrismc mentioned this pull request Jul 19, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

ericLemanissier reviewed Jul 19, 2023

View reviewed changes

fix(qt): remove freetype to QtWidget dependency list

6949aa8

conan-center-bot added the Failed label Jul 19, 2023

This comment has been minimized.

Sign in to view

ledocc added 2 commits July 19, 2023 17:54

fix(qt): remove CMakeToolchain generator from generators attribute, a…

8f56071

…lready in generate() method

fix(qt): remove useless cmake function

7fab7fb

ericLemanissier reviewed Jul 19, 2023

View reviewed changes

ledocc and others added 3 commits July 19, 2023 18:21

Update recipes/qt/5.x.x/test_package/conanfile.py

da538d6

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

Apply suggestions from code review

008c7cd

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

Apply suggestions from code review

6461d2a

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

This comment has been minimized.

Sign in to view

refacto(qt): clean up test_package/target.cmake

63408b7

This comment has been minimized.

Sign in to view

fix(qt): add Gamepad to 3DInput dependency list only if gamepad is en…

a98ea8a

…able

This comment has been minimized.

Sign in to view

conan-center-bot added Service Under Maintenance and removed Failed labels Jul 24, 2023

This comment has been minimized.

Sign in to view

ghost mentioned this pull request Aug 7, 2023

Add QuickPrivate module #19082

Merged

3 tasks

conan-center-bot added Failed and removed Service Under Maintenance labels Aug 8, 2023

ghost mentioned this pull request Aug 10, 2023

clang does not support -rpath-link #19137

Closed

3 tasks

ghost mentioned this pull request Sep 13, 2023

(#19767) qt: exclude examples from license pattern #19768

Merged

3 tasks

stale bot added the stale label Sep 17, 2023

ghost mentioned this pull request Sep 24, 2023

qt5: fix build with apple-clang 15 + add package_type + bump deps + use version range for zlib #20093

Merged

3 tasks

ghost mentioned this pull request Oct 5, 2023

Qt 5.15.11 #20375

Merged

3 tasks

ghost mentioned this pull request Oct 29, 2023

qt/5.15.11: Expose QSvgPlugin and QSvgIconPlugin #20817

Merged

3 tasks

This was referenced Nov 7, 2023

'python2 --version' sends output to stderr, redirect to stdout to cat… #20979

Closed

Fix assembly error in qt5 webengine module with binutils >= 2.41 #21026

Closed

ghost mentioned this pull request Nov 25, 2023

qt/5.x.x: bump sqlite3 #21362

Merged

3 tasks

ghost mentioned this pull request Dec 26, 2023

qt 5.15.12 #21943

Merged

3 tasks

ghost mentioned this pull request Jan 3, 2024

qt/5.x.x: Fix opengl/system dependency to not be required when using es2 #22132

Open

4 tasks

ghost mentioned this pull request Jan 19, 2024

qt5: fix qt3D without qtgamepad #22437

Merged

3 tasks

ghost mentioned this pull request Feb 5, 2024

qt: update libpng/1.6.42 #22675

Merged

3 tasks

ghost mentioned this pull request Feb 28, 2024

qt: Bump expat to 2.6.0 to avoid conflicts in xkbcommon and wayland #22929

Merged

3 tasks

ghost mentioned this pull request Mar 8, 2024

qt 5.15.13 #23034

Merged

3 tasks

This was referenced Mar 18, 2024

qt5: remove unused patch #23155

Merged

qt: add options to enable several modules at once #23171

Merged

ghost mentioned this pull request Mar 26, 2024

qt/5: Use libglvnd on FreeBSD and Linux #23280

Closed

This was referenced Apr 13, 2024

qt: security, bump expat, sqlite #23517

Closed

qt: don't enable disabled options #23571

Closed

qt: force use of bundled xcb-xinput #23572

Closed

Qt5: fix crash at launch on Android < 23 #23659

Closed

github-actions bot closed this Apr 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(qt): improve qt test_package and fix qt libs dependencies #18650

feat(qt): improve qt test_package and fix qt libs dependencies #18650

ledocc commented Jul 19, 2023 •

edited

Loading

CLAassistant commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Jul 19, 2023

ghost commented Jul 19, 2023 •

edited by ghost

Loading

ericLemanissier left a comment

ericLemanissier Jul 19, 2023

ledocc Jul 19, 2023

ledocc Jul 19, 2023

ericLemanissier Jul 19, 2023

ledocc Jul 19, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Aug 8, 2023

stale bot commented Sep 17, 2023

github-actions bot commented Apr 22, 2024

leha-bot commented Apr 24, 2024

ledocc commented Apr 29, 2024

		if self.options.get_safe("with_x11", False):
		gui_reqs.append("xorg::xorg")

feat(qt): improve qt test_package and fix qt libs dependencies #18650

feat(qt): improve qt test_package and fix qt libs dependencies #18650

Conversation

ledocc commented Jul 19, 2023 • edited Loading

CLAassistant commented Jul 19, 2023 • edited Loading

github-actions bot commented Jul 19, 2023

ghost commented Jul 19, 2023 • edited by ghost Loading

ericLemanissier left a comment

Choose a reason for hiding this comment

ericLemanissier Jul 19, 2023

Choose a reason for hiding this comment

ledocc Jul 19, 2023

Choose a reason for hiding this comment

ledocc Jul 19, 2023

Choose a reason for hiding this comment

ericLemanissier Jul 19, 2023

Choose a reason for hiding this comment

ledocc Jul 19, 2023 • edited Loading

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Aug 8, 2023

Conan v1 pipeline ❌

stale bot commented Sep 17, 2023

github-actions bot commented Apr 22, 2024

leha-bot commented Apr 24, 2024

ledocc commented Apr 29, 2024

ledocc commented Jul 19, 2023 •

edited

Loading

CLAassistant commented Jul 19, 2023 •

edited

Loading

ghost commented Jul 19, 2023 •

edited by ghost

Loading

ledocc Jul 19, 2023 •

edited

Loading