Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightgbm: migrate to Conan v2, add v4.0.0 #18759

Merged
merged 9 commits into from
Dec 4, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 20, 2023

TODO:

  • v1: Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES)

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Jul 21, 2023

@uilianries Can you help with this one as well, please?
ERROR: Missing prebuilt package for 'fast_double_parser/0.7.0'

@uilianries
Copy link
Member

@valgur I just started an internal build to generate fast_double_parser/0.7.0

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

ERROR: Missing binary: fast_double_parser/0.7.0:da39a3ee5e6b4b0d3255bfef95601890afd80709

It's in the build queue, there are more builds running right now.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries uilianries self-assigned this Nov 6, 2023
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, revert to patches as before, so we can track that change. Plus, I opened a PR to the upstream: microsoft/LightGBM#6178

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 10 (934ec52bcd58b9833bae0917bcc797f26579f54d):

  • lightgbm/4.1.0:
    All packages built successfully! (All logs)

  • lightgbm/3.3.5:
    All packages built successfully! (All logs)

  • lightgbm/3.3.2:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 10 (934ec52bcd58b9833bae0917bcc797f26579f54d):

  • lightgbm/4.1.0:
    All packages built successfully! (All logs)

  • lightgbm/3.3.5:
    All packages built successfully! (All logs)

  • lightgbm/3.3.2:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 4524ed6 into conan-io:master Dec 4, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants