Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shaderc: migrate to Conan v2, simplify patching, add v2023.6 #18807

Merged
merged 10 commits into from
Apr 30, 2024
Merged

shaderc: migrate to Conan v2, simplify patching, add v2023.6 #18807

merged 10 commits into from
Apr 30, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 22, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 11, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@stale stale bot removed the stale label Sep 20, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur marked this pull request as ready for review September 20, 2023 10:28
@valgur valgur changed the title shaderc: migrate to Conan v2 shaderc: migrate to Conan v2, simplify patching, add v2023.6 Sep 20, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Sep 20, 2023
Open
Closed
@ericLemanissier ericLemanissier mentioned this pull request Sep 20, 2023
Closed
@Ahajha
Copy link
Contributor

Ahajha commented Oct 27, 2023

Interested in this MR, is this just waiting for reviews for dependency version updates, or is there something I can help with?

@valgur valgur mentioned this pull request Oct 31, 2023
Merged
3 tasks
@valgur valgur mentioned this pull request Nov 8, 2023
Open
@prince-chrismc prince-chrismc mentioned this pull request Feb 21, 2024
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
AbrilRBS
AbrilRBS previously approved these changes Apr 30, 2024
View reviewed changes
czoido
czoido previously approved these changes Apr 30, 2024
View reviewed changes
@AbrilRBS AbrilRBS self-assigned this Apr 30, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@AbrilRBS AbrilRBS dismissed stale reviews from czoido and themself via 91134c9 April 30, 2024 16:02
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (91134c975323c5a6bedc1377b09dc1dd9668ccda):

  • shaderc/2021.1:
    All packages built successfully! (All logs)

  • shaderc/2023.6:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (91134c975323c5a6bedc1377b09dc1dd9668ccda):

  • shaderc/2023.6:
    All packages built successfully! (All logs)

  • shaderc/2021.1:
    All packages built successfully! (All logs)

@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 91134c9
shaderc/2021.1@#6a76c2a8ece37f940dc832a2e65f86bc 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libshaderc_shared.dylib, libshaderc_shared.1.dylib

@conan-center-bot conan-center-bot merged commit ba9b2ae into conan-io:master Apr 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@czoido czoido czoido approved these changes

@franramirez688 franramirez688 Awaiting requested review from franramirez688

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@valgur @conan-center-bot @Ahajha @czoido @AbrilRBS @jwillikers