Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ags: migrate to Conan v2 #18831

Merged
merged 8 commits into from
Nov 16, 2023
Merged

ags: migrate to Conan v2 #18831

merged 8 commits into from
Nov 16, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 22, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Jul 27, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur marked this pull request as ready for review August 7, 2023 18:41
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Aug 7, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries uilianries self-assigned this Nov 6, 2023
uilianries
uilianries reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option shared has been removed and is not marked as static library, but the previous version had support to .dll. Please, check what is needed to work with DLL again.

@valgur valgur mentioned this pull request Nov 8, 2023
Open
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (a154dddcc26de1a2a2148721fd1b833ed7cf3920):

  • ags/6.0.1:
    All packages built successfully! (All logs)

  • ags/6.1.0:
    All packages built successfully! (All logs)

  • ags/5.4.1:
    All packages built successfully! (All logs)

  • ags/6.2.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (a154dddcc26de1a2a2148721fd1b833ed7cf3920):

  • ags/5.4.1:
    All packages built successfully! (All logs)

  • ags/6.2.0:
    All packages built successfully! (All logs)

  • ags/6.1.0:
    All packages built successfully! (All logs)

  • ags/6.0.1:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 2b6e90b into conan-io:master Nov 16, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@jwillikers jwillikers jwillikers approved these changes

Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valgur @conan-center-bot @uilianries @AbrilRBS @jwillikers