-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure-storage-cpp: migrate to Conan v2 #18842
azure-storage-cpp: migrate to Conan v2 #18842
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again. |
This comment has been minimized.
This comment has been minimized.
This requires openssl.
I believe it was automagically grabbing the openssl which was required by cpprestsdk in the past, but now that's not being passed in. We could either add the "transitive_header=True" argument to cpprestsdk's openssl, or require openssl for this package as well. Given that the azure-storage-cpp code directly includes openssl on non-windows platforms, I think we should add a requires to this recipe.
This is the usage.
|
1b97a27
to
882f0f9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
be2c683
to
9568949
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
due to libuuid version conflict
cedbb01
to
e9b8004
Compare
This comment has been minimized.
This comment has been minimized.
One of the remaining green migration PRs. Another review would be welcome. |
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 (
|
.