Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-storage-cpp: migrate to Conan v2 #18842

Merged
merged 20 commits into from
Aug 20, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 23, 2023

.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Oct 12, 2023
3 tasks
@bemehiser
Copy link
Contributor

bemehiser commented Oct 13, 2023

@valgur

This requires openssl.

/home/conan/w/prod-v1/bsr/48/+6d3bb/.conan/data/azure-storage-cpp/7.5.0/_/_/source/src/Microsoft.WindowsAzure.Storage/src/hashing.cpp:268:51: warning: ‘int SHA256_Final(unsigned char*, SHA256_CTX*)’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
         SHA256_Final(m_hash.data(), m_hash_context);

I believe it was automagically grabbing the openssl which was required by cpprestsdk in the past, but now that's not being passed in. We could either add the "transitive_header=True" argument to cpprestsdk's openssl, or require openssl for this package as well.

Given that the azure-storage-cpp code directly includes openssl on non-windows platforms, I think we should add a requires to this recipe.

if self.settings.os != "Windows":
    self.requires("openssl/[>=1.1 <4]")

This is the usage.

// Microsoft.WindowsAzure.Storage/includes/wascore/hashing.h
#ifdef _WIN32
#include <BCrypt.h>
#else
#include <openssl/sha.h>
#include <openssl/md5.h>
#include <openssl/hmac.h>
#endif

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Version conflict There is a version conflict when solving the dependencies graph label Nov 6, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed the Version conflict There is a version conflict when solving the dependencies graph label Nov 6, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added Missing dependencies Build failed due missing dependencies in Conan Center Version conflict There is a version conflict when solving the dependencies graph labels Dec 23, 2023
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 17, 2024
@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Aug 11, 2024

One of the remaining green migration PRs. Another review would be welcome.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (373b9bdb151285ccb3e0187992999c39d9f6e4b6):

  • azure-storage-cpp/7.5.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (373b9bdb151285ccb3e0187992999c39d9f6e4b6):

  • azure-storage-cpp/7.5.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 56d62b7 into conan-io:master Aug 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants