Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godot-cpp: migrate to Conan v2 #18862

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 24, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 16, 2023
@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost
Copy link

ghost commented Sep 21, 2023

I detected other pull requests that are modifying godot-cpp/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (28d64207b5f0f1a6085ff07b3640ed45e11833bb):

  • godot-cpp/3.5.1:
    All packages built successfully! (All logs)

  • godot-cpp/cci.3.2-20200130:
    All packages built successfully! (All logs)

  • godot-cpp/3.3.4:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (28d64207b5f0f1a6085ff07b3640ed45e11833bb):

  • godot-cpp/3.5.1:
    All packages built successfully! (All logs)

  • godot-cpp/cci.3.2-20200130:
    All packages built successfully! (All logs)

  • godot-cpp/3.3.4:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking, found something strange

@AbrilRBS AbrilRBS self-assigned this Jan 15, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about the package_id modification :)

recipes/godot-cpp/all/conanfile.py Show resolved Hide resolved
@conan-center-bot conan-center-bot merged commit 2c58fb5 into conan-io:master Jan 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants