Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc65: migrate to Conan v2 #18873

Merged
merged 10 commits into from
Jan 2, 2024
Merged

cc65: migrate to Conan v2 #18873

merged 10 commits into from
Jan 2, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 24, 2023 •
edited
Loading

No description provided.

@conan-center-bot

This comment has been minimized.

Sign in to view
@danimtb danimtb closed this Jul 24, 2023
@danimtb danimtb reopened this Jul 24, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 16, 2023
@valgur valgur closed this Aug 16, 2023
@valgur valgur reopened this Aug 16, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@valgur valgur closed this Sep 17, 2023
@valgur valgur reopened this Sep 17, 2023
@stale stale bot removed the stale label Sep 17, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 8, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur marked this pull request as ready for review November 17, 2023 15:30
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
cc65: drop test_v1_package
0411590 
It refuses to work despite package_info() and test_v1_package being virtually unchanged.
@valgur
cc65: fix MSVC build
8a93187
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Dec 12, 2023
Open
danimtb
danimtb reviewed Dec 27, 2023
View reviewed changes
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter suggestions

recipes/cc65/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cc65/all/conanfile.py Outdated Show resolved Hide resolved
@danimtb danimtb self-assigned this Dec 27, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 14 (8b7ca95816bcd05047603b0cc9f36348a8bac0dc):

  • cc65/2.18:
    All packages built successfully! (All logs)

  • cc65/2.19:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 14 (8b7ca95816bcd05047603b0cc9f36348a8bac0dc):

  • cc65/2.18:
    All packages built successfully! (All logs)

  • cc65/2.19:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit bfe3521 into conan-io:master Jan 2, 2024
18 checks passed
@SpaceIm
Copy link
Contributor

SpaceIm commented May 26, 2024 •
edited
Loading

@valgur migration of msvc branch is highly suspicious. See zimg recipe for an example of how to inject MSBuild conantoolchain props (yep, it's not automatic, it would require conan-io/conan#12817 which didn't get lot of interest from conan devs).

@valgur
Copy link
Contributor Author

valgur commented May 27, 2024

@SpaceIm Thanks for mentioning. You're welcome to open a PR to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@danimtb danimtb danimtb approved these changes

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valgur @conan-center-bot @SpaceIm @AbrilRBS @danimtb