Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verilator: migrate to Conan v2 #18897

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 25, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 16, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@valgur valgur force-pushed the migrate/verilator branch 2 times, most recently from ea14953 to 85b74ea Compare October 28, 2023 08:17
@stale stale bot removed the stale label Oct 28, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries uilianries self-assigned this Nov 29, 2023
if self.settings.os == "Windows":
self.requires("winflexbison/2.5.25", visible=False)
else:
self.requires("flex/2.6.4", visible=False)
Copy link
Member

@uilianries uilianries Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is flex need now, but not before? Using ldd on linux I don't see linkage. Please, update the PR description with the changes related to this PR, it really hard to track and review without any information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My memory is very fuzzy, it's been almost half a year, sorry. I think it was due to flex being a run-time requirement and getting Conan v1 and v2 to propagate it correctly in the graph were a major pain. I really don't want to touch this part of the recipe again, if possible

Copy link
Contributor

github-actions bot commented Jul 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 4, 2024
@valgur valgur requested a review from uilianries July 4, 2024 07:31
@github-actions github-actions bot removed the stale label Jul 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 5, 2024
@valgur
Copy link
Contributor Author

valgur commented Aug 5, 2024

needs reviewing, not closing

@github-actions github-actions bot removed the stale label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 5, 2024
@valgur
Copy link
Contributor Author

valgur commented Sep 5, 2024

Don't close.

@github-actions github-actions bot removed the stale label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Oct 6, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 6, 2024
@valgur
Copy link
Contributor Author

valgur commented Oct 6, 2024

Don't close.

@AbrilRBS AbrilRBS removed the stale label Oct 6, 2024
@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 6, 2024

@valgur 👍, told the bot not the close this

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 1 (ef59aedf2379c419b07b27bb5076e9a122182400):

  • verilator/4.200:
    Built 6 packages out of 11 (All logs)

  • verilator/4.224:
    Built 6 packages out of 11 (All logs)

  • verilator/5.004:
    Built 6 packages out of 11 (All logs)


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 1 (ef59aedf2379c419b07b27bb5076e9a122182400):

  • verilator/4.224:
    Didn't run or was cancelled before finishing

  • verilator/5.004:
    Didn't run or was cancelled before finishing

  • verilator/4.200:
    Error running command conan graph info --requires verilator/4.200@#3cb58835b65ba274421916c7beb87aab --build verilator/4.200@#3cb58835b65ba274421916c7beb87aab -f json -pr:h /home/conan/workspace/prod-v2/bsr/95636/dccce/profile_windows_192_release_dynamic_14_msvc_release_64..txt -pr:b /home/conan/workspace/prod-v2/bsr/95636/dccce/profile_windows_192_release_dynamic_14_msvc_release_64..txt:

    ======== Computing dependency graph ========
    strawberryperl/5.32.1.1: Not found in local cache, looking in remotes...
    strawberryperl/5.32.1.1: Checking remote: conan-center
    strawberryperl/5.32.1.1: Downloaded recipe revision 707032463aa0620fa17ec0d887f5fe41
    dirent/1.24: Not found in local cache, looking in remotes...
    dirent/1.24: Checking remote: conan-center
    dirent/1.24: Downloaded recipe revision 697499506c82b54dd3eb2a764241b3a1
    winflexbison/2.5.25: Not found in local cache, looking in remotes...
    winflexbison/2.5.25: Checking remote: conan-center
    winflexbison/2.5.25: Downloaded recipe revision 6b08309e90720974e49b4cf745242e64
    msys2/cci.latest: Not found in local cache, looking in remotes...
    msys2/cci.latest: Checking remote: conan-center
    msys2/cci.latest: Downloaded recipe revision f6bb451a181a3f452024ea43ca744061
    automake/1.16.5: Not found in local cache, looking in remotes...
    automake/1.16.5: Checking remote: conan-center
    automake/1.16.5: Downloaded recipe revision 058bda3e21c36c9aa8425daf3c1faf50
    autoconf/2.71: Not found in local cache, looking in remotes...
    autoconf/2.71: Checking remote: conan-center
    autoconf/2.71: Downloaded recipe revision f9307992909d7fb3df459340f1932809
    m4/1.4.19: Not found in local cache, looking in remotes...
    m4/1.4.19: Checking remote: conan-center
    m4/1.4.19: Downloaded recipe revision b38ced39a01e31fef5435bc634461fd2
    ERROR: verilator/4.200 require 'strawberryperl/<host_version>': didn't find a matching host dependency
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants