Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile-project-workspace-creator: migrate to Conan v2 #18938

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 28, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur valgur force-pushed the migrate/makefile-project-workspace-creator branch from a0321d0 to 8eff08d Compare August 18, 2023 09:39
@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@valgur valgur marked this pull request as draft October 25, 2023 14:21
@valgur valgur force-pushed the migrate/makefile-project-workspace-creator branch from 8eff08d to 2cfb509 Compare October 25, 2023 15:44
@valgur valgur marked this pull request as ready for review October 25, 2023 15:45
@valgur valgur force-pushed the migrate/makefile-project-workspace-creator branch from 2cfb509 to c43e30b Compare October 28, 2023 08:17
@stale stale bot removed the stale label Oct 28, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

I just merged the hook exception and pulled master over this PR. It should work now.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur valgur force-pushed the migrate/makefile-project-workspace-creator branch from e014e7c to 7ecb804 Compare November 6, 2023 13:54
@conan-center-bot

This comment has been minimized.

@valgur valgur force-pushed the migrate/makefile-project-workspace-creator branch from 7ecb804 to 003388d Compare November 6, 2023 16:31
@conan-center-bot

This comment has been minimized.

@uilianries uilianries self-assigned this Nov 13, 2023
@valgur valgur force-pushed the migrate/makefile-project-workspace-creator branch from 0ae6b64 to 67d70cc Compare March 24, 2024 13:48
@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS requested review from perseoGI and removed request for jcar87 and franramirez688 June 13, 2024 12:34
perseoGI
perseoGI previously approved these changes Jun 13, 2024
@AbrilRBS AbrilRBS requested a review from perseoGI June 13, 2024 14:18
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member

Simplified this PR a little:

  • Avoided test_v1_package
  • Didn't include strawberry perl for Windows (users should be free to choose)
  • Test package only checks if perl file is packaged

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (9896bc7cfd38f5fc4aace6fcad76ae2991b329d0):

  • makefile-project-workspace-creator/4.1.46:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (9896bc7cfd38f5fc4aace6fcad76ae2991b329d0):

  • makefile-project-workspace-creator/4.1.46:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit bdada53 into conan-io:master Jun 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants