Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libest: migrate to Conan v2 #18947

Merged
merged 10 commits into from
Jan 12, 2024
Merged

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 28, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@conan-center-bot

This comment has been minimized.

To hopefully fix
configure: error: cannot run C compiled programs.
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries uilianries self-assigned this Nov 8, 2023

def requirements(self):
self.requires("openssl/1.1.1q")
self.requires("openssl/1.1.1w", transitive_headers=True, transitive_libs=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.requires("openssl/1.1.1w", transitive_headers=True, transitive_libs=True)
self.requires("openssl/[>=1.1 <4]", transitive_headers=True, transitive_libs=True)

In case it does not support OpenSSL 3.x, you still can use range, but [>=1.1 <3]

https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/dependencies.md#version-ranges

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Using <2 did not work for some reason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uilianries Yeah, this fails on Conan v1 for some reason. Quite annoying.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR: Version range '>=1.1 <3' from requirement 'openssl/[>=1.1 <3]' required by 'libest/3.2.0' could not be resolved in remote 'conan-center'

Only in Conan v1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I'll take a look.

valgur and others added 2 commits November 8, 2023 13:43
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 13 (797a3ca8d1f5bfbee543891a5861a726958efaac):

  • libest/3.2.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 12 (797a3ca8d1f5bfbee543891a5861a726958efaac):

  • libest/3.2.0:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conan 1.x can not solve ranged versions using the format 1.1.1(suffix).

@conan-center-bot conan-center-bot merged commit 65da40a into conan-io:master Jan 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants