-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ofeli: migrate to Conan v2, add v5.1.0 #18952
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, check 5.x compatibility. I didn't find those limitations documented. Or they are improved now, or at least, it should be clarified better.
homepage = "http://ofeli.org/index.html" | ||
topics = ("finite-element", "finite-element-library", "finite-element-analysis", "finite-element-solver") | ||
|
||
package_type = "static-library" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find a reference offering only static library: https://github.com/rtouzani/ofeli/blob/master/src/CMakeLists.txt
Please, point where you found it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A shared build fails with:
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<unsigned long, 3ul>::~LocalVect()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<unsigned long, 2ul>::~LocalVect()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::Muscl::setReconstruction(OFELI::Vect<double> const&, OFELI::Vect<double>&, OFELI::Vect<double>&, unsigned long)'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `virtual thunk to OFELI::LaplaceDG2DP1::build()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 2ul>::get()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 3ul>::LocalVect()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<unsigned long, 3ul>::LocalVect()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<unsigned long, 2ul>::LocalVect()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 3ul>::operator()(unsigned long)'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 2ul>::operator=(double const&)'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 3ul>::get()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 3ul>::~LocalVect()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LaplaceDG2DP1::build()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 1ul>::get()'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 2ul>::operator()(unsigned long)'
ofelia3f8f09b1f9b5/p/lib/libofeli.so: undefined reference to `OFELI::LocalVect<double, 3ul>::operator=(double const&)'
on GCC.
recipes/ofeli/5.x/conanfile.py
Outdated
cmake_layout(self, src_folder="src") | ||
|
||
def validate(self): | ||
if self.settings.os not in ["Linux", "FreeBSD"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README indicates Windows support too: https://github.com/rtouzani/ofeli/blob/master/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember the details why I disabled it anymore. Will give it another shot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#18952 (comment)
Too many compilation errors on MSVC to count.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 14 (
Conan v2 pipeline ✔️
All green in build 14 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.