Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resiprocate: migrate to Conan v2 #18956

Merged
merged 16 commits into from
May 9, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 28, 2023

.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Hooks produced the following warnings for commit 909887c
resiprocate/1.12.0
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/asio/doc/asio/reference/async_result_lt__std__packaged_task_lt__Result_lp_Args_ellipsis__rp__gt__comma__Signature__gt_/get.html' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 1176c39
resiprocate/1.12.0@#3f226865d17cdb50d5e50dc1cc3fe039
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/asio/doc/asio/reference/async_result_lt__std__packaged_task_lt__Result_lp_Args_ellipsis__rp__gt__comma__Signature__gt_/get.html' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 2, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

I just started an internal build to generate libmysqlclient/8.0.34

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Nov 22, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Jan 5, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Hooks produced the following warnings for commit d5637bd
resiprocate/1.12.0@#822d3668302ccac246f9ca1c2080885e
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/asio/doc/asio/reference/async_result_lt__std__packaged_task_lt__Result_lp_Args_ellipsis__rp__gt__comma__Signature__gt_/completion_handler_type.html' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@valgur
Copy link
Contributor Author

valgur commented Jan 5, 2024

@uilianries It looks like the OpenSSL version ranges are really not working as well as might be expected. libmysqlclient has been built with openssl/3.x and the build fails due to a missing libysqlclient binary when using openssl/1.1.1w as the requirement, but finds the binary when OpenSSL 3.x is used.
I'm not sure whether this happens only when the exact version differs or just the major version, but anyway, this renders the OpenSSL version ranges a bit counterproductive in CCI. It replaces a clear version conflict with a very vague "missing binary" one.

Based on this, I would change the OpenSSL dependency version convention to [>=3 <4] or just [^3] for packages compatible with 3.x and 1.1.1w or similar for packages that only support 1.x.

Edit: Tagging @RubenRBS as well, since you were actively involved in the OpenSSL version range update.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 8c55d52
resiprocate/1.12.0@#2cdf10425819d34cfa1fa43888f3206f
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/asio/doc/asio/reference/async_result_lt__std__packaged_task_lt__Result_lp_Args_ellipsis__rp__gt__comma__Signature__gt_/completion_handler_type.html' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librutil-1.12.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librutil.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libresip.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libresip-1.12.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdum.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdum-1.12.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 22 (7962bd488a9393324daba92da356678a3d1ea48c):

  • resiprocate/1.12.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 22 (7962bd488a9393324daba92da356678a3d1ea48c):

  • resiprocate/1.12.0:
    All packages built successfully! (All logs)

Copy link
Contributor

Hooks produced the following warnings for commit 7962bd4
resiprocate/1.12.0@#c1cef86df3ced23e84500e32f9f0c97a
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './contrib/asio/doc/asio/reference/async_result_lt__std__packaged_task_lt__Result_lp_Args_ellipsis__rp__gt__comma__Signature__gt_/completion_handler_type.html' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librutil-1.12.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librutil.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libresip.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libresip-1.12.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdum.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdum-1.12.so' links to system library 'm' but it is not in cpp_info.system_libs.

@danimtb danimtb assigned danimtb and uilianries and unassigned danimtb May 9, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Conan 1.x has limitations with openssl 1.1.1 version range and reciprocate does not support OpenSSL 3.x resiprocate/resiprocate#242

@conan-center-bot conan-center-bot merged commit 275701b into conan-io:master May 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants