Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backward-cpp: add header_only option #19095

Merged
merged 2 commits into from
Oct 27, 2023
Merged

backward-cpp: add header_only option #19095

merged 2 commits into from
Oct 27, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Aug 8, 2023

The library is nearly header-only anyway and is being used as such in #19074, so it made sense to perhaps add the option to the recipe.

Also removed the redundant transitive_libs=True params and made Linux OS detection more consistent.

@prince-chrismc prince-chrismc mentioned this pull request Aug 8, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
AbrilRBS
AbrilRBS reviewed Aug 10, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I only have 1 concern about removing the transitive_libs trait for shared=True in dwarf mode

recipes/backward-cpp/all/conanfile.py Outdated Show resolved Hide resolved
@AbrilRBS AbrilRBS self-assigned this Aug 10, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (7785de0a165428b806ca5a90f6206d1b182286fa):

  • backward-cpp/1.6:
    All packages built successfully! (All logs)

  • backward-cpp/1.5:
    All packages built successfully! (All logs)

  • backward-cpp/1.4:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (7785de0a165428b806ca5a90f6206d1b182286fa):

  • backward-cpp/1.5:
    All packages built successfully! (All logs)

  • backward-cpp/1.6:
    All packages built successfully! (All logs)

  • backward-cpp/1.4:
    All packages built successfully! (All logs)

@valgur
Copy link
Contributor Author

valgur commented Oct 24, 2023

@RubenRBS Another ping, just in case.

@valgur valgur requested a review from AbrilRBS October 24, 2023 19:19
@AbrilRBS
Copy link
Member

Thanks!

@conan-center-bot conan-center-bot merged commit 66072f8 into conan-io:master Oct 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@jwillikers jwillikers jwillikers approved these changes

@uilianries uilianries Awaiting requested review from uilianries

@franramirez688 franramirez688 Awaiting requested review from franramirez688

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valgur @conan-center-bot @AbrilRBS @jwillikers