-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mold 2.0.0 #19152
Add mold 2.0.0 #19152
Conversation
I detected other pull requests that are modifying mold/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Can anybody advise how to solve the CI issue? Seems like some package is missing. In the #conan Slack channel I was told that somebody from the team has to run a build for missing packages? |
I'd love to have mold 2.0 in conan. The error you are getting seems to be in |
@mgehre-amd IMO I didn't change anything there. On the slack channel somebody told me I have to wait for the team to help with that but I don't know what to do with this issue or how to get in contact. |
The The #18848 PR should help with any Conan v1 issues in the mold v1 recipe, once it gets merged. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fschoenm Thank you for your contribution, good catch with the license change! Please, let's keep it simpler:
- Keep everything in the same recipe, there is no big change that justify such duplication.
- You can change the license according the version, it's something already used in CCI: https://github.com/conan-io/conan-center-index/blob/master/recipes/jfalcou-eve/all/conanfile.py#L41
This comment has been minimized.
This comment has been minimized.
57592aa
to
14e8996
Compare
@uilianries Thanks for the pointer, I didn't know that is possible. Maybe could be added to the contribution documentation (or maybe I just didn't see it) :) |
@fschoenm changing a recipe is something rare, but indeed it deserves be documented. I'll open a PR soon. |
This comment has been minimized.
This comment has been minimized.
14e8996
to
226063c
Compare
226063c
to
232b2c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE!
Is there a problem with the CI system? It says something about an unexpected error. |
@uilianries Unfortunately, it still didn't work. I saw that there's a onetbb package depending on hwloc/2.9.Z on conancenter:
But the build requires onetbb depending on hwloc/2.9.3:
I'm not really sure what it means. I think it has something to do with |
There was problem related to the OneTBB and its supported package IDs, but I created a PR fixing it: #20786 I just started the PR again. Let's if it works now. |
b74861f
to
e8a921b
Compare
This comment has been minimized.
This comment has been minimized.
@uilianries Sorry but that's no fix at all. It doesn't change the fact, that the onetbb package required for mold needs hwloc/2.9.3 instead of hwloc/2.9.Z.
|
Here is a possible explanation: conan-io/conan#15040 (comment) |
#20897 should avoid missing package id for this case. It may lead to other issues related to missing packages in downstream recipes. |
e8a921b
to
77830d5
Compare
This comment has been minimized.
This comment has been minimized.
You have to wait a little bit after merge of a PR (not just 3 min), before new packages can be available. |
77830d5
to
e84abbd
Compare
This comment has been minimized.
This comment has been minimized.
458f2bf
to
f768735
Compare
Conan v1 pipeline ✔️All green in build 12 (
Conan v2 pipeline ✔️
All green in build 14 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, asking @franramirez688 for an extra review.
@uilianries Anything missing here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* mold: add version 2.0.0 * Requires at least CMake 3.18
Specify library name and version: mold/2.0.0
Essentially a version bump. mold 2.0.0 has been relicensed from AGPL to MIT (see Release Notes for mold 2.0.0), which is why I moved the old all folder to 1.x.x and created a new all folder that essentially only changed the
license
attribute. I hope that's the correct approach.