Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-snmp: migrate to Conan v2 #19227

Merged
merged 22 commits into from
Sep 4, 2024
Merged

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Aug 16, 2023

No description provided.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@stale stale bot removed the stale label Nov 3, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 17, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 9021e52
net-snmp/5.9.4@#50a2ff2f435494d001d6d85bdd7acaa1
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libnetsnmp.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libnetsnmp.dylib, libnetsnmp.40.dylib

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member

uilianries commented Aug 30, 2024

I did some changes to this PR, I guess is okay at current state to be merged in case passing:

  • MSVC actually works, only fails when building shared library
  • OpenSSL 3.x is also support, added range versions: net-snmp 5.9.4 and its supported OpenSSL version net-snmp/net-snmp#768
  • Removed Neutrino support. It comes from another PR, and we have no build log that ensure it's working.
  • Add missing system libraries and frameworks
  • Removed CMake as build requirement for test package. I remember there was an old bug, but fixed in Conan client at some point.
  • Added pkg-config as tool requirement in order to find OpenSSL when cross-building on Mac.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@uilianries uilianries self-assigned this Sep 2, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 11 (9fe841686e33c9a971fd1598b071edb285e93ca7):

  • net-snmp/5.9.4:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 11 (9fe841686e33c9a971fd1598b071edb285e93ca7):

  • net-snmp/5.9.4:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit b55601e into conan-io:master Sep 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants