Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-proto: fix package type and settings #19759

Closed
wants to merge 1 commit into from

Conversation

tuxu
Copy link
Contributor

@tuxu tuxu commented Sep 12, 2023

opentelemetry-proto packages the protobuf definitions for OpenTelemetry. Marking it as a "build-script" implied visibility=False to downstream packages like opentelemetry, which made a CppInfo quality check fail with "required component package 'opentelemetry-proto::' not in dependencies".

This also removes settings, since there is no actual build step and the package won't be affected by any config properties.

Fixes #18967.


opentelemetry-proto packages the protobuf definitions for OpenTelemetry.
Marking it as a "build-script" implied visibility=False to downstream
packages like opentelemetry, which made a CppInfo quality check fail
with "required component package 'opentelemetry-proto::' not in
dependencies".

This also removes settings, since there is no actual build step and the
package won't be affected by any config properties.

Fixes conan-io#18967.
@CLAassistant
Copy link

CLAassistant commented Sep 12, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (ee11cbc1f8b27b5a243fc4e52f16f70a339952c2):

  • opentelemetry-proto/1.0.0:
    All packages built successfully! (All logs)

  • opentelemetry-proto/0.20.0:
    All packages built successfully! (All logs)

  • opentelemetry-proto/0.18.0:
    All packages built successfully! (All logs)

  • opentelemetry-proto/0.19.0:
    All packages built successfully! (All logs)

  • opentelemetry-proto/0.17.0:
    All packages built successfully! (All logs)

  • opentelemetry-proto/0.16.0:
    All packages built successfully! (All logs)

  • opentelemetry-proto/0.11.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (ee11cbc1f8b27b5a243fc4e52f16f70a339952c2):

  • opentelemetry-proto/0.17.0:
    All packages built successfully! (All logs)

  • opentelemetry-proto/0.20.0:
    All packages built successfully! (All logs)

  • opentelemetry-proto/0.18.0:
    All packages built successfully! (All logs)

  • opentelemetry-proto/1.0.0:
    All packages built successfully! (All logs)

  • opentelemetry-proto/0.19.0:
    All packages built successfully! (All logs)

  • opentelemetry-proto/0.11.0:
    All packages built successfully! (All logs)

  • opentelemetry-proto/0.16.0:
    All packages built successfully! (All logs)

@AbrilRBS
Copy link
Member

Thanks for bringing it up to our attention. I'll check if there's a package type that better fits the use-case just in case :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] opentelemetry-cpp/1.9.1: fails to build due to broken opentelemetry-proto dependency
6 participants