Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frugally-deep version 0.15.24-p0 #19953

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Add frugally-deep version 0.15.24-p0 #19953

merged 4 commits into from
Oct 2, 2023

Conversation

Dobiasd
Copy link
Contributor

@Dobiasd Dobiasd commented Sep 19, 2023

No description provided.

@Dobiasd Dobiasd mentioned this pull request Sep 19, 2023
Closed
@prince-chrismc prince-chrismc mentioned this pull request Sep 19, 2023
Open
@ericLemanissier ericLemanissier mentioned this pull request Sep 19, 2023
Closed
This was referenced Sep 19, 2023
Open
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@Dobiasd
Copy link
Contributor Author

Dobiasd commented Sep 19, 2023

Are the failing CI jobs real errors, or do the jobs just need to be re-run?

@Dobiasd Dobiasd changed the title Add frugally-deep version 0.15.21-p0 Add frugally-deep version 0.15.22-p0 Sep 20, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@AbrilRBS
Copy link
Member

It seems to be real error when running tests for visual studio with the new version in both cases yes
Maybe the new version needs a newer visual studio or something?

@AbrilRBS AbrilRBS self-assigned this Sep 20, 2023
@Dobiasd
Copy link
Contributor Author

Dobiasd commented Sep 20, 2023

Is there a way for me to view the error log from the Visual Studio tests?

@Dobiasd
Copy link
Contributor Author

Dobiasd commented Sep 20, 2023

Ah, I found this.

That looks weird. The tests in the frugally-deep CI succeed. 🧐

@Dobiasd Dobiasd changed the title Add frugally-deep version 0.15.22-p0 Add frugally-deep version 0.15.23-p0 Sep 20, 2023
@Dobiasd
Copy link
Contributor Author

Dobiasd commented Sep 20, 2023

Oh, yes, that was a real issue in my code. I just fixed it, released a new version, and updated this pull request accordingly.

AbrilRBS
AbrilRBS previously approved these changes Sep 20, 2023
View reviewed changes
@jcar87 jcar87 mentioned this pull request Sep 20, 2023
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@Dobiasd Dobiasd changed the title Add frugally-deep version 0.15.23-p0 Add frugally-deep version 0.15.24-p0 Sep 22, 2023
@Dobiasd
Copy link
Contributor Author

Dobiasd commented Sep 30, 2023

@RubenRBS The PR logs say that I dismissed your review. Sorry, this was not my intention, and I don't remember doing this.

Is something blocking this PR?

@AbrilRBS
Copy link
Member

No worries, Github auto dismisses reviews when new commits are pushed, so that no unreviewed changes get thru - I see that the new runs are failing, will investigate the reason

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (7e00b6d71a9fa97f513ff7deeffece8a49712b7b):

  • frugally-deep/0.15.18-p0:
    All packages built successfully! (All logs)

  • frugally-deep/0.15.19-p0:
    All packages built successfully! (All logs)

  • frugally-deep/0.15.16-p0:
    All packages built successfully! (All logs)

  • frugally-deep/0.15.24-p0:
    All packages built successfully! (All logs)

  • frugally-deep/0.15.13-p0:
    All packages built successfully! (All logs)

  • frugally-deep/0.15.1-p0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (7e00b6d71a9fa97f513ff7deeffece8a49712b7b):

  • frugally-deep/0.15.19-p0:
    All packages built successfully! (All logs)

  • frugally-deep/0.15.18-p0:
    All packages built successfully! (All logs)

  • frugally-deep/0.15.16-p0:
    All packages built successfully! (All logs)

  • frugally-deep/0.15.13-p0:
    All packages built successfully! (All logs)

  • frugally-deep/0.15.1-p0:
    All packages built successfully! (All logs)

  • frugally-deep/0.15.24-p0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit af79694 into conan-io:master Oct 2, 2023
37 checks passed
@Dobiasd Dobiasd mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@ericLemanissier ericLemanissier ericLemanissier approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dobiasd @conan-center-bot @AbrilRBS @ericLemanissier