Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ruby's zlib requirement to [>=1.2.11 <2] range (v1 only) #20659

Closed

Conversation

AbrilRBS
Copy link
Member

Part of the zlib range migration, this PR only supports Conan v1

@AbrilRBS AbrilRBS self-assigned this Oct 18, 2023
@ghost
Copy link

ghost commented Oct 18, 2023

I detected other pull requests that are modifying ruby/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 1 (e501be663c7cc065fb3f19d24b038a921704cf56):

  • ruby/3.1.0:
    CI failed to create some packages (All logs)

    Logs for packageID 7304b0d8a30f301edc3b37cacf8f99914affd91e:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.libcxx=libc++
    compiler.version=13.0
    os=Macos
    [options]
    ruby:shared=True
    
    [...]
    OSSL_DEPRECATEDIN_3_0
    ^
    /usr/local/Cellar/openssl@3/3.1.3/include/openssl/macros.h:193:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
    #   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
                                                    ^
    /usr/local/Cellar/openssl@3/3.1.3/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
    #     define OSSL_DEPRECATED(since) __attribute__((deprecated))
                                                       ^
    In file included from /Users/jenkins/w/prod-v1/bsr/30521/caaed/.conan/data/ruby/3.1.0/_/_/build/7304b0d8a30f301edc3b37cacf8f99914affd91e/source_subfolder/ext/openssl/ossl_ssl_session.c:5:
    In file included from /Users/jenkins/w/prod-v1/bsr/30521/caaed/.conan/data/ruby/3.1.0/_/_/build/7304b0d8a30f301edc3b37cacf8f99914affd91e/source_subfolder/ext/openssl/ossl.h:171:
    /Users/jenkins/w/prod-v1/bsr/30521/caaed/.conan/data/ruby/3.1.0/_/_/build/7304b0d8a30f301edc3b37cacf8f99914affd91e/source_subfolder/ext/openssl/openssl_missing.h:195:11: warning: 'TS_VERIFY_CTS_set_certs' macro redefined [-Wmacro-redefined]
    #  define TS_VERIFY_CTS_set_certs(ctx, crts) ((ctx)->certs=(crts))
              ^
    /usr/local/Cellar/openssl@3/3.1.3/include/openssl/ts.h:426:11: note: previous definition is here
    #  define TS_VERIFY_CTS_set_certs(ctx, cert) TS_VERIFY_CTX_set_certs(ctx,cert)
              ^
    1 warning generated.
    6 warnings generated.
    In file included from /Users/jenkins/w/prod-v1/bsr/30521/caaed/.conan/data/ruby/3.1.0/_/_/build/7304b0d8a30f301edc3b37cacf8f99914affd91e/source_subfolder/ext/openssl/ossl_ts.c:10:
    In file included from /Users/jenkins/w/prod-v1/bsr/30521/caaed/.conan/data/ruby/3.1.0/_/_/build/7304b0d8a30f301edc3b37cacf8f99914affd91e/source_subfolder/ext/openssl/ossl.h:171:
    /Users/jenkins/w/prod-v1/bsr/30521/caaed/.conan/data/ruby/3.1.0/_/_/build/7304b0d8a30f301edc3b37cacf8f99914affd91e/source_subfolder/ext/openssl/openssl_missing.h:195:11: warning: 'TS_VERIFY_CTS_set_certs' macro redefined [-Wmacro-redefined]
    #  define TS_VERIFY_CTS_set_certs(ctx, crts) ((ctx)->certs=(crts))
              ^
    /usr/local/Cellar/openssl@3/3.1.3/include/openssl/ts.h:426:11: note: previous definition is here
    #  define TS_VERIFY_CTS_set_certs(ctx, cert) TS_VERIFY_CTX_set_certs(ctx,cert)
              ^
    /Users/jenkins/w/prod-v1/bsr/30521/caaed/.conan/data/ruby/3.1.0/_/_/build/7304b0d8a30f301edc3b37cacf8f99914affd91e/source_subfolder/ext/openssl/ossl_ts.c:829:5: error: incomplete definition of type 'struct TS_verify_ctx'
        TS_VERIFY_CTX_set_certs(ctx, x509inter);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /Users/jenkins/w/prod-v1/bsr/30521/caaed/.conan/data/ruby/3.1.0/_/_/build/7304b0d8a30f301edc3b37cacf8f99914affd91e/source_subfolder/ext/openssl/openssl_missing.h:215:46: note: expanded from macro 'TS_VERIFY_CTX_set_certs'
    #  define TS_VERIFY_CTX_set_certs(ctx, crts) TS_VERIFY_CTS_set_certs(ctx, crts)
                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /Users/jenkins/w/prod-v1/bsr/30521/caaed/.conan/data/ruby/3.1.0/_/_/build/7304b0d8a30f301edc3b37cacf8f99914affd91e/source_subfolder/ext/openssl/openssl_missing.h:195:52: note: expanded from macro 'TS_VERIFY_CTS_set_certs'
    #  define TS_VERIFY_CTS_set_certs(ctx, crts) ((ctx)->certs=(crts))
                                                  ~~~~~^
    /usr/local/Cellar/openssl@3/3.1.3/include/openssl/ts.h:407:16: note: forward declaration of 'struct TS_verify_ctx'
    typedef struct TS_verify_ctx TS_VERIFY_CTX;
                   ^
    1 warning and 1 error generated.
    make[2]: *** [ossl_ts.o] Error 1
    make[1]: *** [ext/openssl/all] Error 2
    make[1]: *** Waiting for unfinished jobs....
    make: *** [build-ext] Error 2
    ruby/3.1.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    ruby/3.1.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    ruby/3.1.0: ERROR: Package '7304b0d8a30f301edc3b37cacf8f99914affd91e' build failed
    ruby/3.1.0: WARN: Build folder /Users/jenkins/w/prod-v1/bsr/30521/caaed/.conan/data/ruby/3.1.0/_/_/build/7304b0d8a30f301edc3b37cacf8f99914affd91e
    ERROR: ruby/3.1.0: Error in build() method, line 140
    	at.make()
    	ConanException: Error 2 while executing make -j4
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 1 (e501be663c7cc065fb3f19d24b038a921704cf56):

  • ruby/3.1.0:
    Error running command conan export --name ruby --version 3.1.0 recipes/ruby/all/conanfile.py:
    ======== Exporting recipe to the cache ========
    ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-20659/recipes/ruby/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-20659/recipes/ruby/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod-v2_cci_PR-20659/recipes/ruby/all/conanfile.py", line 16, in <module>
        from conans import tools
    ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit e501be6
ruby/3.1.0@#dde06cce09d30b27fb766959c93f606a
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libruby.3.1.dylib, libruby.dylib

@AbrilRBS
Copy link
Member Author

Closing in favour of #18338

@AbrilRBS AbrilRBS closed this Oct 23, 2023
@AbrilRBS AbrilRBS deleted the rr/auto-bumpdeps-v1/zlib/ruby branch October 23, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants