Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liburing: Add 2.3+2.4 and update to Conan 2 #21061

Merged
merged 13 commits into from
Nov 14, 2023

Conversation

Ahajha
Copy link
Contributor

@Ahajha Ahajha commented Nov 10, 2023

Specify library name and version: liburing/2.3

@Ahajha
Copy link
Contributor Author

Ahajha commented Nov 10, 2023

This is a continuation of #19739

@Ahajha
Copy link
Contributor Author

Ahajha commented Nov 10, 2023

Locally, still figuring out why the --nolibc option is failing on older versions, and shared library installs seem to be broken. Will figure out if this is a regression or not.

@ghost
Copy link

ghost commented Nov 10, 2023

I detected other pull requests that are modifying liburing/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@Ahajha
Copy link
Contributor Author

Ahajha commented Nov 10, 2023

For some reason, with the new changes liburing.so, a symlink, ends up broken. For now, I have a fix that just removes it and makes a new symlink. If anyone has any ideas of how to fix it, let me know and I'll update it.

@conan-center-bot

This comment has been minimized.

@Ahajha Ahajha changed the title liburing: Add 2.3 and update to Conan 2 liburing: Add 2.3+2.4 and update to Conan 2 Nov 12, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ahajha

Thanks a lot for the contribution. It's looking great! Several comments before merging the PR 😁

recipes/liburing/all/conanfile.py Outdated Show resolved Hide resolved
recipes/liburing/all/conanfile.py Outdated Show resolved Hide resolved
recipes/liburing/all/conanfile.py Outdated Show resolved Hide resolved
@franramirez688 franramirez688 self-assigned this Nov 14, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (0a467de65336b98980fd46997ff26f9634dd1a63):

  • liburing/2.4:
    All packages built successfully! (All logs)

  • liburing/2.3:
    All packages built successfully! (All logs)

  • liburing/2.2:
    All packages built successfully! (All logs)

  • liburing/2.1:
    All packages built successfully! (All logs)

  • liburing/2.0:
    All packages built successfully! (All logs)

  • liburing/0.7:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (0a467de65336b98980fd46997ff26f9634dd1a63):

  • liburing/2.3:
    All packages built successfully! (All logs)

  • liburing/2.2:
    All packages built successfully! (All logs)

  • liburing/2.0:
    All packages built successfully! (All logs)

  • liburing/2.4:
    All packages built successfully! (All logs)

  • liburing/0.7:
    All packages built successfully! (All logs)

  • liburing/2.1:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit a24477f into conan-io:master Nov 14, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants