cpp-lazy: add version 8.0.0 #23236
cpp-lazy: add version 8.0.0 #23236
Conversation
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
| @@ -14,6 +14,8 @@ def layout(self): | |||
|
|
|||
| def requirements(self): | |||
| self.requires(self.tested_reference_str) | |||
| # cpp-lazy>=8.0.0 requires fmt library when neither LZ_STANDALONE or LZ_MODULE_EXPORT are not defined | |||
There was a problem hiding this comment.
Shouldn't this be a proper requirement in the conanfile.py then?
There was a problem hiding this comment.
Looks like so to me too @toge :)
There was a problem hiding this comment.
@jwillikers @RubenRBS
Sorry for the late reply.
If the user has defined LZ_STANDALONE and LZ_MODULE_EXPORT, cpp-lazy does not require the fmtlib.
Once LZ_MODULE_EXPORT is defined, cpp-lazy will require the C++ module.
Since cpp-lazy supports c++11 or later, it is not a portable test.
If we want to keep the portability of cpp-lazy, I think we would require fmtlib only in tests.
There was a problem hiding this comment.
Hi! Lets bring this PR back to life!
Which is the minimum supported standard for fmt? I guess if it is greater than C++11 this make sense.
Specify library name and version: cpp-lazy/8.0.0
cpp-lazy/8.0.0 has added support for modules, fmtlib is now required regardless of whether standalone is set or not if the module is not exported.
MarcDirven/cpp-lazy@v7.0.2...v8.0.0