-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt6: prevent finding zstd when it is disabled #24701
qt6: prevent finding zstd when it is disabled #24701
Conversation
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 1 (
|
Hooks produced the following warnings for commit 415b3acqt/6.7.1@#36c25b343703345eefaccd43bac02b19
qt/6.7.0@#7a0dca522c5cc760ac22e0c066f714ed
qt/6.6.0@#c96d97ae00c69e632ba9a4869ed218ad
qt/6.6.1@#683dac33de111a2f33634e0b9dc2f9d0
qt/6.6.3@#b1e098c68a8bcbfefc71700404f13611
qt/6.6.2@#3e8cade501d4142bc3309679ed206236
qt/6.3.2@#64339adb17c17e3077ade02cc4c7ab4f
qt/6.5.3@#e06a51aa5592c851ec28597a13fcbfd5
qt/6.4.2@#2888a1f1f959da406744dd06920abed3
|
Summary
Changes to recipe: qt/6
Motivation
Fix #24639
Details
the qt build system searches for zstd even when it is not required - the zstd find logic searches for "thread". If zstd is present (outside of conan), it will find it, which causes to search for
Thread::Thread
as a transitive dependency, and when it comes to promoting the target to global, it will fail.This prevents cmake from locating zstd when it is not explicitly required by the recipe.