-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix definition for glog #2500
Fix definition for glog #2500
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Some configurations of 'glog/0.4.0' failed in build 1 (
|
Signed-off-by: Uilian Ries <uilianries@gmail.com>
All green in build 2 (
|
Signed-off-by: Uilian Ries <uilianries@gmail.com>
All green in build 3 (
|
It's weird. When I try to build
Click to expand log
Click to expand log
|
I would love CCI to reproduce those errors... we are not using exactly the same VS version, but I wouldn't expect those errors. Maybe related to ninja? Any other big difference in your build? |
Except Visual Studio 2019 version and Ninja generator, no difference I think. |
I'll try to reproduce later, but before pushing it was working on my machine. |
I'm running MSVC 19.26.28806.0 too, but I see no errors: Glog 0.4.0 as static: Click to expand logExporting package recipe glog/0.4.0 exports: File 'conandata.yml' found. Exporting it... glog/0.4.0 exports: Copied 1 '.yml' file: conandata.yml glog/0.4.0 exports_sources: Copied 1 '.txt' file: CMakeLists.txt glog/0.4.0 exports_sources: Copied 1 '.patch' file: fix-cmake.patch glog/0.4.0: The stored package has not changed glog/0.4.0: Exported revision: 534d506951fe40f5c4bb1f7b01bf3f7b Configuration: [settings] arch=x86_64 arch_build=x86_64 build_type=Release compiler=Visual Studio compiler.runtime=MD compiler.version=16 os=Windows os_build=Windows [options] glog:shared=False [build_requires] [env] CONAN_CMAKE_GENERATOR=Ninja glog/0.4.0: Forced build from source glog/0.4.0 (test package): Installing package Requirements gflags/2.2.2 from 'conan-center' - Cache glog/0.4.0 from local cache - Cache Packages gflags/2.2.2:276ecda833039958fbea98273ce18f54031274b8 - Cache glog/0.4.0:7388bbc133673b4a6d4abbc3dc58a3c2c9fc3fa4 - BuildInstalling (downloading, building) binaries... ** Visual Studio 2019 Developer Command Prompt v16.6.2 [vcvarsall.bat] Environment initialized for: 'x64' ** Visual Studio 2019 Developer Command Prompt v16.6.2 [vcvarsall.bat] Environment initialized for: 'x64' [2/9] Building CXX object source_subfolder\CMakeFiles\glog.dir\src\demangle.cc.obj [3/9] Building CXX object source_subfolder\CMakeFiles\glog.dir\src\symbolize.cc.obj [4/9] Building CXX object source_subfolder\CMakeFiles\glog.dir\src\utilities.cc.obj [5/9] Building CXX object source_subfolder\CMakeFiles\glog.dir\src\vlog_is_on.cc.obj [6/9] Building CXX object source_subfolder\CMakeFiles\glog.dir\src\raw_logging.cc.obj [7/9] Building CXX object source_subfolder\CMakeFiles\glog.dir\src\signalhandler.cc.obj [8/9] Building CXX object source_subfolder\CMakeFiles\glog.dir\src\logging.cc.obj [9/9] Linking CXX static library lib\glog.lib glog/0.4.0: Package '7388bbc133673b4a6d4abbc3dc58a3c2c9fc3fa4' built ** Visual Studio 2019 Developer Command Prompt v16.6.2 [vcvarsall.bat] Environment initialized for: 'x64' -- Install configuration: "Release" ** Visual Studio 2019 Developer Command Prompt v16.6.2 [vcvarsall.bat] Environment initialized for: 'x64'
-- Build files have been written to: C:/Users/uilia/Development/conan/conan-center-index/recipes/glog/all/test_package/build/0dacb45415de6fc57c5a88360430ac62dd6dcca1 ** Visual Studio 2019 Developer Command Prompt v16.6.2 [vcvarsall.bat] Environment initialized for: 'x64' [2/2] Linking CXX executable bin\test_package.exe glog/0.4.0 (test package): Running test() Glog 0.4.0 as shared (same warnings, but no errors): Click to expand logExporting package recipe glog/0.4.0 exports: File 'conandata.yml' found. Exporting it... glog/0.4.0 exports: Copied 1 '.yml' file: conandata.yml glog/0.4.0 exports_sources: Copied 1 '.txt' file: CMakeLists.txt glog/0.4.0 exports_sources: Copied 1 '.patch' file: fix-cmake.patch glog/0.4.0: The stored package has not changed glog/0.4.0: Exported revision: 534d506951fe40f5c4bb1f7b01bf3f7b Configuration: [settings] arch=x86_64 arch_build=x86_64 build_type=Release compiler=Visual Studio compiler.runtime=MD compiler.version=16 os=Windows os_build=Windows [options] glog:shared=True [build_requires] [env] CONAN_CMAKE_GENERATOR=Ninja glog/0.4.0: Forced build from source glog/0.4.0 (test package): Installing package Requirements gflags/2.2.2 from 'conan-center' - Cache glog/0.4.0 from local cache - Cache Packages gflags/2.2.2:ed160c62813fa6d86d309b2f7e6e791ae96da725 - Cache glog/0.4.0:0f6c072dc37dcbff023d073d38a3da84abbd1529 - BuildInstalling (downloading, building) binaries... ** Visual Studio 2019 Developer Command Prompt v16.6.2 [vcvarsall.bat] Environment initialized for: 'x64' ** Visual Studio 2019 Developer Command Prompt v16.6.2 [vcvarsall.bat] Environment initialized for: 'x64' [2/9] Building CXX object source_subfolder\CMakeFiles\glog.dir\src\raw_logging.cc.obj [3/9] Building CXX object source_subfolder\CMakeFiles\glog.dir\src\demangle.cc.obj [4/9] Building CXX object source_subfolder\CMakeFiles\glog.dir\src\signalhandler.cc.obj [5/9] Building CXX object source_subfolder\CMakeFiles\glog.dir\src\symbolize.cc.obj [6/9] Building CXX object source_subfolder\CMakeFiles\glog.dir\src\vlog_is_on.cc.obj source_subfolder\src\vlog_is_on.cc(53): warning C4273: 'fLI::FLAGS_v': inconsistent dll linkage [8/9] Building CXX object source_subfolder\CMakeFiles\glog.dir\src\logging.cc.obj source_subfolder\src\logging.cc(107): warning C4273: 'fLB::FLAGS_logtostderr': inconsistent dll linkage Creating library lib\glog.lib and object lib\glog.exp LINK : warning LNK4217: symbol '?FLAGS_v@fLI@@3Ha (int fLI::FLAGS_v)' defined in 'vlog_is_on.cc.obj' is imported by 'logging.cc.obj' in function '"bool __cdecl google::SendEmailInternal(char const *,char const *,char const *,bool)" (?SendEmailInternal@google@@YA_NPEBD00_N@Z)' LINK : warning LNK4217: symbol '?FLAGS_logtostderr@fLB@@3_NA (bool fLB::FLAGS_logtostderr)' defined in 'logging.cc.obj' is imported by 'raw_logging.cc.obj' in function '"void cdecl google::RawLog(int,char const *,int,char const *,...)" (?RawLog__@google@@YAXHPEBDH0ZZ)' LINK : warning LNK4217: symbol '?FLAGS_alsologtostderr@fLB@@3_NA (bool fLB::FLAGS_alsologtostderr)' defined in 'logging.cc.obj' is imported by 'raw_logging.cc.obj' in function '"void cdecl google::RawLog(int,char const *,int,char const *,...)" (?RawLog__@google@@YAXHPEBDH0ZZ)' LINK : warning LNK4217: symbol '?FLAGS_stderrthreshold@fLI@@3Ha (int fLI::FLAGS_stderrthreshold)' defined in 'logging.cc.obj' is imported by 'raw_logging.cc.obj' in function '"void cdecl google::RawLog(int,char const *,int,char const *,...)" (?RawLog__@google@@YAXHPEBDH0ZZ)' glog/0.4.0: Package '0f6c072dc37dcbff023d073d38a3da84abbd1529' built ** Visual Studio 2019 Developer Command Prompt v16.6.2 [vcvarsall.bat] Environment initialized for: 'x64' -- Install configuration: "Release" ** Visual Studio 2019 Developer Command Prompt v16.6.2 [vcvarsall.bat] Environment initialized for: 'x64'
-- Build files have been written to: C:/Users/uilia/Development/conan/conan-center-index/recipes/glog/all/test_package/build/393822ae0969dfcc234d52d2991e58c705978bd6 ** Visual Studio 2019 Developer Command Prompt v16.6.2 [vcvarsall.bat] Environment initialized for: 'x64' [2/2] Linking CXX executable bin\test_package.exe glog/0.4.0 (test package): Running test() I have to investigate the origin of those warnings, but I can't reproduce the same error. Probably the warning is connected to the errors. |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
config.yml syntax error in build 4:
|
The warning seems be related to the namespace added by glog to redefine glags definitions. I've asked to the author about it: google/glog#569. I'll update as soon as I have a new answer. |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
config.yml syntax error in build 5:
|
Signed-off-by: Uilian Ries <uilianries@gmail.com>
All green in build 6 (
|
@@ -489,7 +489,7 @@ if (WIN32 AND HAVE_SNPRINTF) | ||
@@ -469,7 +469,6 @@ add_library (glog | ||
) | ||
add_library(glog::glog ALIAS glog) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this alias needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't matter, it's part of patch context. Always tedious to review modifications of patch files 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ouch! I got confused with those +
, I thought we were adding those lines here 🤦
Specify library name and version: glog/0.4.0
fixes #2494
/cc @SpaceIm @ShamanTcler
conan-center hook activated.