theora: add package_type, simplify test_package, fix component name #25394
+24
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
AbrilRBS
reviewed
Sep 25, 2024
| @@ -73,9 +72,9 @@ def package(self): | |||
| def package_info(self): | |||
| self.cpp_info.set_property("pkg_config_name", "theora_full_package_do_not_use") # to avoid conflicts with theora component | |||
|
|
|||
| self.cpp_info.components["theora"].set_property("pkg_config_name", "theora") | |||
There was a problem hiding this comment.
This might be a noobie question, but what's the insight behind this fix? Is it related to the global name in consumer requires clauses, in which using theora::theora would bring unexpected requirements? Thanks!
There was a problem hiding this comment.
That's exactly the reason, yeah. There's no way to distinguish between the whole-package "component" and the subcomponent otherwise. Pango, Cairo and some other recipes use a similar naming scheme for the core component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: theora/1.1.1
Motivation
Details