-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qcustomplot: add package_type, transitive_headers=True #25405
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, thanks for the fix!
|
||
def requirements(self): | ||
if Version(self.version) >= "2.0.0": | ||
self.requires("qt/6.4.1") | ||
self.requires("qt/[>=6.4 <7]", transitive_headers=True, transitive_libs=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this never worked in Conan 2 then? Nice catch if so!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why transitive_libs BTW?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_package without transitive_libs=True:
undefined reference to symbol '_ZN7QWidget11setGeometryERK5QRect@@Qt_6'
qt00e75f421b97e/p/lib/libQt6Widgets.so.6: error adding symbols: DSO missing from command line
Conan v1 pipeline ❌Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
I don't have any good ideas on how to approach the |
Summary
Changes to recipe: qcustomplot/[*]
Motivation
Details
test_package fails to link with
transitive_libs=False
.The OpenGL direct dependency should not be necessary since the code only uses qtOpenGL and not OpenGL itself.