-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simple_enum: add new version 0.8.4 #26028
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some questions about the new version and our dependency handling :)
@@ -1,4 +1,7 @@ | |||
sources: | |||
"0.8.4": | |||
url: "https://github.com/arturbac/simple_enum/archive/refs/tags/v0.8.4.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, the new version requires C++23 arturbac/simple_enum@v0.8.0...v0.8.4
#diff-1e7de1ae2d
Also, I wonder how the glaze requirement is being handled in this case, it seems like it depends on it unconditionally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbrilRBS
Thank you!
Now requires C++23 on 0.8.4.
While glaze is optional, I think it is not required.
If someone wants to use simple_enum and glaze integration, they simply include glaze_json_enum_name.hpp with installed glaze.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reading from https://github.com/arturbac/simple_enum/blob/v0.8.4/CMakeLists.txt#L33 is that glaze would be needed if we were using the CMake installation (Plus a defines too?) Can you double check? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbrilRBS
Thanks!
I didn't read CMakeLists.txt so much.
While I can use simple_enum without glaze, I will follow official CMakeLists.txt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. Should we ask upstream about it, see if they support this no-glaze-drpendency case?
Summary
Changes to recipe: simple_enum/0.8.4
Motivation
There are several improvements since 0.8.0.
Details
arturbac/simple_enum@v0.8.0...v0.8.4