-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opencascade: Add 7.8.1 #26087
base: master
Are you sure you want to change the base?
opencascade: Add 7.8.1 #26087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No changes in the building: Open-Cascade-SAS/OCCT@V7_8_0...V7_8_1#files_bucket
tc.variables["CMAKE_CXX_STANDARD"] = self._min_cppstd | ||
if Version(self.version) >= "7.8.0": | ||
cppstd = str(self.settings.compiler.cppstd).replace("gnu", "").upper() | ||
tc.cache_variables["BUILD_CPP_STANDARD"] = f"C++{cppstd}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/Open-Cascade-SAS/OCCT/blob/master/CMakeLists.txt#L25 this value actually is not enfornced because upstream has a , so it's not an actual fatal error
Current error on Linux:
|
Summary
Changes to recipe: opencascade/[7.8.1]
Motivation
Closes #25738
Details
Lots of cleanup that I left for a follow-up PR, and #20781 has this as a subset, but realized it too late. Will merge both PRs
Open-Cascade-SAS/OCCT@V7_6_2...V7_8_1 very big diff! But not much build-side changes