Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implot/0.11 #6328

Merged
merged 4 commits into from
Jul 16, 2021
Merged

Add implot/0.11 #6328

merged 4 commits into from
Jul 16, 2021

Conversation

hnOsmium0001
Copy link
Contributor

Specify library name and version: implot/0.11

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@github-actions github-actions bot mentioned this pull request Jul 14, 2021
Open
prince-chrismc
prince-chrismc reviewed Jul 14, 2021
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions for you!

recipes/implot/all/CMakeLists.txt Show resolved Hide resolved
recipes/implot/all/CMakeLists.txt Show resolved Hide resolved
recipes/implot/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
hnOsmium0001 and others added 2 commits July 14, 2021 08:47
@hnOsmium0001 @madebr
Apply suggestions from code review
808967a 
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
@hnOsmium0001
Remove tests for find_package
4a908a1
@conan-center-bot
Copy link
Collaborator

All green in build 4 (4a908a147972875377bf497c790f1f6a2ffdd96b):

  • implot/0.11@:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Jul 16, 2021
View reviewed changes
recipes/implot/all/CMakeLists.txt
@@ -0,0 +1,27 @@
cmake_minimum_required(VERSION 3.4)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. epezent/implot#125

@conan-center-bot conan-center-bot merged commit 7ba58d2 into conan-io:master Jul 16, 2021
@hnOsmium0001 hnOsmium0001 deleted the implot branch July 16, 2021 19:37
AndreyMlashkin pushed a commit to AndreyMlashkin/conan-center-index that referenced this pull request Jul 19, 2021
@hnOsmium0001 @madebr @AndreyMlashkin
(conan-io#6328) Add implot/0.11
b756a13 
* Add implot

* Add imgui to implot cpp_info.requires

* Apply suggestions from code review

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>

* Remove tests for find_package

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
@SpaceIm SpaceIm mentioned this pull request Mar 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madebr madebr madebr approved these changes

@uilianries uilianries uilianries approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hnOsmium0001 @conan-center-bot @madebr @uilianries @prince-chrismc