-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try GameNetworkingSockets #7040
Try GameNetworkingSockets #7040
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package_info()
and a test_package are missing
So, GameNetworkingSockets unconditionally builds both the static and shared libraries here. Should I surround these by an if-else in a patch? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
It's basically C at this point!
This comment has been minimized.
This comment has been minimized.
|
Patches are hard to maintain. Probably the cleanest way, would be to see if upstream would accept an optional build setting to only build one of them. The easier one would be to just delete the respective unwanted library in
You can add a package both as a requirement and as a build_requirement. You also have to use two Conan profiles, both together should accomplish this (but I have almost zero hands-on experience with that setup myself, so I can't really help further)
If that is nothing that can be easily fixed, then exclude these old, unsupported compilers. Something along the lines of:
|
Co-authored-by: Michael Keck <git@cr0ydon.com>
Co-authored-by: Michael Keck <git@cr0ydon.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
9802805
to
5d1c88a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
So, |
That's odd... we have a bunch of recipes that do this... Also I just wrote #7621 to do exactly that 😕 conan-center-index/recipes/simple-websocket-server/all/conanfile.py Lines 45 to 46 in 41d4fbb
It's a topic in another PR as well #7510 (comment) |
Please do not force push 🙏 GitHub forces us to restart the review which is not fun! |
This comment has been minimized.
This comment has been minimized.
Oh, i didn't know that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thank you for your contribution
All green in build 22 (
|
Specify library name and version: game-networking-sockets/1.3.0
I saw this listed on #621 and thought it would be a good addition to CCI.
Closes #7589
conan-center hook activated.