Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add draco/1.3.5 #725

Merged
merged 3 commits into from
Jan 29, 2020
Merged

add draco/1.3.5 #725

merged 3 commits into from
Jan 29, 2020

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 23, 2020

Specify library name and version: draco/1.3.5

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'draco/1.3.5' failed in build 1 (813e0e373f00f410c5eb2beb2bfc8962235c5a5c):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'draco/1.3.5' failed in build 2 (49db47cb3721d72245a3036230c64ac6be20e06b):

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 23, 2020

C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppBuild.targets(312,5): error MSB3491: Could not write lines to file "draco_compression_attributes_pred_schemes_dec.dir\Debug\draco_co.517E10AA.tlog\draco_compression_attributes_pred_schemes_dec.lastbuildstate". The specified path, file name, or both are too long. The fully qualified file name must be less than 260 characters, and the directory name must be less than 248 characters. [C:\J\c3ipr\pr_725_2_0_2\.conan\data\draco\1.3.5\_\_\build\8a53c449afc5d7e043474b43b2844541ed168c33\build_subfolder\source_subfolder\draco_compression_attributes_pred_schemes_dec.vcxproj]

C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppBuild.targets(312,5): error MSB3491: Could not write lines to file "draco_compression_attributes_pred_schemes_enc.dir\Debug\draco_co.83C85316.tlog\draco_compression_attributes_pred_schemes_enc.lastbuildstate". The specified path, file name, or both are too long. The fully qualified file name must be less than 260 characters, and the directory name must be less than 248 characters. [C:\J\c3ipr\pr_725_2_0_2\.conan\data\draco\1.3.5\_\_\build\8a53c449afc5d7e043474b43b2844541ed168c33\build_subfolder\source_subfolder\draco_compression_attributes_pred_schemes_enc.vcxproj]

Seems to be related to dotnet/msbuild#53

Is long paths enabled?

Co-Authored-By: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 3 (b3bf31e4bb6ddfc9df48e82dc06b3f1a7983beaa)! 😊

@madebr
Copy link
Contributor

madebr commented Jan 24, 2020

@uilianries
This package only needs short_paths when building, not when consuming the package.
Is it possible to instruct this to Conan?

@uilianries
Copy link
Member

@madebr maybe by configure(self), but I'm not sure, only checking the code/behavior:

def configure(self):
    self.short_path = self.develop

@madebr
Copy link
Contributor

madebr commented Jan 24, 2020

@uilianries

def configure(self):
    self.short_path = self.develop

I tried this but got the following error:

ERROR: The 'draco/1.3.5' package has 'exports_sources' but sources not found in local cache.
Probably it was installed from a remote that is no longer available.

This would be a nice feature for a next conan release, wouldn't it?
Essentially, only source_folder and build_folder should be "short_paths", package_folder can be normal.

@uilianries
Copy link
Member

@madebr It's not possible using a condition for short_paths in Conanfile.py, I've checked now, both code and behavior. You can open a feature request if you are interested on it.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, apply the changes recommended by @madebr

Co-Authored-By: Anonymous Maarten <madebr@users.noreply.github.com>
@conan-center-bot
Copy link
Collaborator

All green in build 4 (a110c2ac681288c081adf252ac27bf957b61ad6a)! 😊

@SSE4 SSE4 removed the request for review from danimtb January 27, 2020 05:58
@danimtb danimtb self-assigned this Jan 29, 2020
@danimtb danimtb merged commit 50f0769 into conan-io:master Jan 29, 2020
@SpaceIm SpaceIm deleted the add-draco-1.3.5 branch January 29, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants