-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add net-snmp/5.9.1 #8668
Add net-snmp/5.9.1 #8668
Conversation
This comment has been minimized.
This comment has been minimized.
105d8c6
to
7db4072
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@jgsogo Is this potentially a bug in the Epochs feature? IIUC this PR should not run GCC 11 builds if the deps aren't there |
yes, clearly, something is wrong with epoch computation here, and in few other PRs |
We deployed a fix for this. It is working now! |
5220c24
to
ccf4229
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a65ba7c
to
5ef2dfc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I have no means to test/reproduce/investigate this error locally. cc @SpaceIm since it's an error on MacOS |
I think this is the same error that is fixed in some other recipes adding a def build_requirements(self):
if self.settings.os == "Macos" and self.settings.arch == "armv8":
# Attempting to use @rpath without CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG being
# set. This could be because you are using a Mac OS X version less than 10.5
# or because CMake's platform configuration is corrupt.
self.build_requires("cmake/3.20.1") |
It seems that this is related to CMP0068, which was added in 3.9. Simply changing the minimum requirement of the test package to However, I'm not sure this is the proper solution. CMake built libraries do not need anything like this. Maybe something in the build scripts of this project should be done to fix up installed binaries. |
@friendlyanon I don't think it's related to CMP0068, but you can try. For sure, @jgsogo suggestion will fix this issue in test package for macOS M1, it has been tested in many recipes. |
So, the problem was that CMake doesn't even support macOS on ARM before 3.19.2 and even then, this bug in particular was fixed in the 3.20.1 release. This problem didn't manifest itself for me before, because apparently dependencies disabled this particular configuration in other recipes I submitted. |
Yes. As mentioned by @SSE4 in another PR, maybe macOS M1 agent in CI should have CMake >= 3.20.1 by default. |
That was the conclusion in Slack as well :) |
This comment has been minimized.
This comment has been minimized.
recipes/net-snmp/all/conanfile.py
Outdated
|
||
@property | ||
def _is_msvc(self): | ||
return self._settings_build.compiler in ("Visual Studio", "msvc") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why settings_build here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure actually. I believe I may have copy-pasted this from somewhere without much thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sure you want self.settings.compiler
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I push a fix, where can I read about the significance of settings_build
and where it should be used? Also, is it used properly in validate()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
settings
refers to settings of host profile (target), and settings_build
to settings of build profile (stuff coming from build requirements and logic related to build machine).
Also, is it used properly in validate()?
Maybe, maybe not.
Can it be cross-built from windows to another OS with another compiler than msvc, from linux to Windows with minGW?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be cross-built from windows to another OS with another compiler than msvc, from linux to Windows with minGW?
Provided that the _build_unix()
method is invoked, I don't believe there is anything preventing this from being cross-compiled on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it means that MinGW should work, and there is no reason to prevent Windows build with MinGW on Windows.
This comment has been minimized.
This comment has been minimized.
All green in build 2 (
|
Specify library name and version: net-snmp/5.9.1
Issue: #8618
conan-center hook activated.