Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cereal/1.3.0 #881

Merged
merged 2 commits into from
Feb 20, 2020
Merged

add cereal/1.3.0 #881

merged 2 commits into from
Feb 20, 2020

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Feb 14, 2020

Specify library name and version: cereal/1.3.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

#621

Adapted from https://github.com/conan-community/conan-cereal

closes #879

@conan-center-bot
Copy link
Collaborator

All green in build 1 (9e9318d11eeb47b85936e258f2f221b346314edf)! 😊

recipes/cereal/all/conanfile.py Show resolved Hide resolved
recipes/cereal/all/conanfile.py Outdated Show resolved Hide resolved
Co-Authored-By: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 2 (ff361d1211a833408e45d79b2ed7fedb8bfc982a)! 😊

@danimtb danimtb mentioned this pull request Feb 20, 2020
@danimtb danimtb self-assigned this Feb 20, 2020
@danimtb danimtb merged commit 1477c08 into conan-io:master Feb 20, 2020
@SpaceIm SpaceIm deleted the add-cereal-1.3.0 branch February 20, 2020 10:46
@tonyelewis
Copy link

Thanks very much everyone.

@Croydon
Copy link
Contributor

Croydon commented Feb 22, 2020

https://github.com/conan-community/conan-cereal should get archived

@uilianries
Copy link
Member

Thanks for the reminder!

@stilgarpl
Copy link

stilgarpl commented Apr 10, 2020

cereal-1.3.0 seems to be missing cmake config file, but it was present in 1.2.2. Is this a bug in conan recipe?
I think it is removed by this line in recipe:
tools.rmdir(os.path.join(self.package_folder, "share"))
It wasn't present in 1.2.2 recipe, why was it added?

@Croydon
Copy link
Contributor

Croydon commented Apr 10, 2020

@stilgarpl
Copy link

@Croydon But without those config files, how to use imported targets for packages? Some packages have more than one and conan find_package generator can't handle that.

@uilianries
Copy link
Member

@stilgarpl Could you open a new issue to discuss about it, this PR is finished. Also, could you include more details, like the targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] cereal/1.3.0
9 participants