-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add btyacc/3.0 #8947
Add btyacc/3.0 #8947
Conversation
This comment has been minimized.
This comment has been minimized.
I have no clue how to handle that MacOS CI error. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c1bc69b
to
9d97539
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the license ❤️
This comment has been minimized.
This comment has been minimized.
From discussions on the FirebirdSQL mailing list, it appears that this is just a build requirement of developer workflows when working on FirebirdSQL. However, I'm not sure whether this serves a general use-case or not. Does flex/bison/similar do basically the same as this does? If no, then I don't see a reason why this couldn't be packaged as well. |
We are also missing some CMake targets https://github.com/ChrisDodd/btyacc/blob/0256b69f36f01877f1f4e76f80a5f561beabcfef/CMakeLists.txt#L69-L71 |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
add_executable(test_package "${bin}/main.c") | ||
|
||
enable_testing() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we don't use ctest because it hides the output and also because we don't use assert statement on test package code. But I'm okay as it doesn't affect the test result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I used CTest here was because I don't know whether run
spawns a shell, where I can pipe things, or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice trick!
All green in build 2 (
|
Specify library name and version: btyacc/3.0
This is a build requirement of fbclient.
Issue: #8618
conan-center hook activated.