Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add btyacc/3.0 #8947

Merged
merged 7 commits into from
Mar 10, 2022
Merged

Conversation

friendlyanon
Copy link
Contributor

Specify library name and version: btyacc/3.0

This is a build requirement of fbclient.
Issue: #8618


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@friendlyanon
Copy link
Contributor Author

I have no clue how to handle that MacOS CI error.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the license ❤️

@conan-center-bot

This comment has been minimized.

@friendlyanon
Copy link
Contributor Author

From discussions on the FirebirdSQL mailing list, it appears that this is just a build requirement of developer workflows when working on FirebirdSQL. However, I'm not sure whether this serves a general use-case or not. Does flex/bison/similar do basically the same as this does? If no, then I don't see a reason why this couldn't be packaged as well.

@prince-chrismc
Copy link
Contributor

@conan-center-bot

This comment has been minimized.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


add_executable(test_package "${bin}/main.c")

enable_testing()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we don't use ctest because it hides the output and also because we don't use assert statement on test package code. But I'm okay as it doesn't affect the test result.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I used CTest here was because I don't know whether run spawns a shell, where I can pipe things, or not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick!

@uilianries uilianries closed this Mar 10, 2022
@uilianries uilianries reopened this Mar 10, 2022
@conan-center-bot
Copy link
Collaborator

All green in build 2 (9f7fce906dc8eb0c9ca0e784cc5e4b96903ff67c):

  • btyacc/3.0@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit d031cc3 into conan-io:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants