Add libavif/0.9.3 #9225
Add libavif/0.9.3 #9225
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| #include <avif/avif.h> | ||
| #include <stddef.h> | ||
|
|
||
| int main(int argc, char const* argv[]) |
There was a problem hiding this comment.
The standard prototype of the main() function does not have the "const":
int main(int argc, char* argv[])
See https://en.cppreference.com/w/c/language/main_function
Also, there is an alternative prototype that you can use here to avoid the (void)argc and (void)argv casts.
int main(void)
There was a problem hiding this comment.
All true, I just had such a template I have been using to make recipes. Adding const is also inconsequential in C.
Regardless, I have edited my template and will avoid doing this in the future.
recipes/libavif/all/conanfile.py
Outdated
| required_conan_version = ">=1.43.0" | ||
|
|
||
| codecs = { | ||
| "aom": "libaom-av1/3.1.2", |
There was a problem hiding this comment.
The current libaom release is 3.2.0. Is libaom 3.2.0 available in Conan?
Similarly for dav1d. The current dav1d release is 0.9.2.
There was a problem hiding this comment.
Those are the latest versions currently packaged in CCI.
recipes/libavif/all/conanfile.py
Outdated
| def _configure_cmake(self): | ||
| cmake = CMake(self) | ||
| suffix = str(self.options.with_codec).upper() | ||
| cmake.definitions[f"AVIF_CODEC_{suffix}"] = True |
There was a problem hiding this comment.
For libaom, you can additionally pass -DAVIF_CODEC_AOM_DECODE=OFF to cmake so that libaom is only used as an AV1 encoder.
There was a problem hiding this comment.
I'm not sure that's an option worth exposing here. What is the value proposition of that?
There was a problem hiding this comment.
If -DAVIF_CODEC_AOM=ON is passed to cmake, libaom can be used as both the AV1 encoder and the AV1 decoder. If -DAVIF_CODEC_DAV1D=ON is also passed to cmake, both dav1d and libaom can be used as AV1 decoders, with dav1d preferred over libaom. It suffices to just have dav1d as the AV1 decoder. That's why I suggested passing -DAVIF_CODEC_AOM_DECODE=OFF to cmake.
The code disabled by -DAVIF_CODEC_AOM_DECODE=OFF is mainly in libavif/src/codec_aom.c, some in libavif/src/avif.c. You can evaluate it and see if it's worth making recipes/libavif/all/conanfile.py more complicated.
There was a problem hiding this comment.
So, the value proposition here is that when possible, libavif prefers dav1d, because it's better in some way? If so, I guess it's no biggie to create separate with_encoder and with_decoder options.
There was a problem hiding this comment.
Okay, I had wrong assumptions. I implemented with_decoder only instead with the encoder being aom always.
There was a problem hiding this comment.
@friendlyanon I somehow forgot to reply to your last question. Sorry. Yes, as an AV1 decoder, dav1d has much better performance than libaom.
There was a problem hiding this comment.
Yes, I assumed as such, that's why I set it as the default decoder. Thanks for confirming!
This comment has been minimized.
This comment has been minimized.
The part checking for the version is touching code that is too out of date in the source tarball and it's not essential either.
This comment has been minimized.
This comment has been minimized.
The previous option was implemented based on false assumptions. To encode, there is only AOM in CCI, but the decoder can be swapped to Dav1d, which upstream prefers when available, so it's implemented as the default decoder in the recipe.
|
All green in build 6 (
|
| @functools.lru_cache(1) | ||
| def _configure_cmake(self): | ||
| cmake = CMake(self) | ||
| cmake.definitions["AVIF_CODEC_AOM"] = True |
There was a problem hiding this comment.
If self.options.shared is true, should we pass -DBUILD_SHARED_LIBS=ON to the cmake command for libavif?
There was a problem hiding this comment.
It's handled automatically by Conan.
|
|
||
| self.cpp_info.libs = ["avif"] | ||
| if self.options.shared: | ||
| self.cpp_info.defines = ["AVIF_DLL"] |
There was a problem hiding this comment.
<avif/avif.h> has the following comment:
// AVIF_DLL should be defined if libavif is a shared library. If you are using
// libavif as CMake dependency, through CMake package config file or through
// pkg-config, this is defined automatically.
Since you seem to be defining AVIF_DLL manually, does this mean you are not using libavif as CMake dependency or through pkg-config?
There was a problem hiding this comment.
CMake package configs generated by projects are discarded as per Conan Center Index policy. Conan regenerates CMake package configs at install time using its own generators.
recipes/libavif/all/conanfile.py
Outdated
| def _configure_cmake(self): | ||
| cmake = CMake(self) | ||
| suffix = str(self.options.with_codec).upper() | ||
| cmake.definitions[f"AVIF_CODEC_{suffix}"] = True |
There was a problem hiding this comment.
@friendlyanon I somehow forgot to reply to your last question. Sorry. Yes, as an AV1 decoder, dav1d has much better performance than libaom.
There was a problem hiding this comment.
@friendlyanon I reviewed the latest files (to the best of my abilities because I am not familiar with Conan). I have two questions.
Specify library name and version: libavif/0.9.3
Issue: #8618
conan-center hook activated.