Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang11: update libc++ #320

Merged
merged 4 commits into from
Oct 1, 2021
Merged

clang11: update libc++ #320

merged 4 commits into from
Oct 1, 2021

Conversation

ericLemanissier
Copy link
Contributor

libc++-dev is version 6: https://packages.ubuntu.com/bionic/libc++-dev

Changelog: (Feature | Fix | Bugfix): Describe here your pull request

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've followed the Best Practices guides for Dockerfile.

@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented Oct 1, 2021

I just realized it was already proposed in #252 but it looks like there was no newer docker image which came to fix the issue.
Having workarounds like this on CCI is very scary:
https://github.com/conan-io/conan-center-index/blob/1585b34/recipes/imagl/all/conanfile.py#L100-L101
https://github.com/conan-io/conan-center-index/blob/31bc51816892ca56427f9d5550d3890cb91ac6ac/recipes/andreasbuhr-cppcoro/all/conanfile.py#L67-L68
(I'll have to do the same to make conan-io/conan-center-index#7469 pass)

@uilianries
Copy link
Member

@ericLemanissier my concern about this PR is backward compatibility. I'm not sure if this change will break or not Conan packages already in Conan center and built by Clang 11 with libc++-6

@ericLemanissier
Copy link
Contributor Author

according to https://releases.llvm.org/11.1.0/projects/libcxx/docs/DesignDocs/ABIVersioning.html it depends on cmake variable LIBCXX_ABI_VERSION used when building libc++. It is translated into c++ macro _LIBCPP_ABI_VERSION.
Current dockerio/clang11 has: /usr/include/c++/v1/__config:#define _LIBCPP_ABI_VERSION 1
With this PR we get /usr/lib/llvm-11/include/c++/v1/__config:# define _LIBCPP_ABI_VERSION 1 https://dev.azure.com/conanio/conan-docker-tools/_build/results?buildId=908&view=logs&j=e2666bbb-ec41-51a9-9241-02be2ffb2f19&t=9a0fad47-b207-55a8-8ea7-787dc35161c6&l=1889

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built Poco/1.11.0 and boost/1.76.0@ using this images, with all dependencies using the current libc++ version and worked.

clang_11/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants