initial attempt at feature for adding arguments for docker call #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
suggested changes
Jan 9, 2019
| envs = self.get_env_vars() | ||
| env_vars_text = " ".join(['-e %s="%s"' % (key, value) | ||
| for key, value in envs.items() if value]) | ||
| docker_args_str = " ".join(docker_args) |
|
|
||
| if docker_args is None: | ||
| docker_args = [] | ||
| self.docker_args = docker_args |
There was a problem hiding this comment.
If it shouldn't be false it is better to do self.docker_args = docker_args or []
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #277
Feedback welcome.