fix azure pipelines branch detection #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use variable BUILD_SOURCEBRANCH BUILD_SOURCEBRANCHNAME only has the part after last /
|
If I understand, branch names like "testing/0.1.0" will result in "0.1.0". Is that right? I think we should open an issue to Azure team. |
|
I don't think so, the difference between SourceBranche and SourceBranchName is properly documented on https://docs.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml#build-variables |
|
understood, thanks for sharing |
lasote
added a commit
that referenced
this pull request
Mar 29, 2019
* allow passing user-specified Docker args during create step * rename parameter * mention CONAN_DOCKER_RUN_OPTIONS envvar in readme * add tests * #343 Improve docker integration test - Fix conan_pip_package. It should be a str by default - Pass original printer to be re-used by Docker runner - Add integration test to validate docker run options Signed-off-by: Uilian Ries <uilianries@gmail.com> * #343 Fix skip test when running docker Signed-off-by: Uilian Ries <uilianries@gmail.com> * Add GitHub settings (#345) (#349) * Add GitHub settings - Use standard Conan tags for issues - Add stale config for timeout bot - Add issue template Signed-off-by: Uilian Ries <uilianries@gmail.com> * Use Github settings from conanio/docs Signed-off-by: Uilian Ries <uilianries@gmail.com> * #345 Add PR template - Add PR template to generate the changelog - Add the contributing guide Signed-off-by: Uilian Ries <uilianries@gmail.com> * Trigger Github Settings (#352) Signed-off-by: Uilian Ries <uilianries@gmail.com> * #336 Forward login method (#344) Signed-off-by: Uilian Ries <uilianries@gmail.com> * Upload package dependencies (#334) * #237 Update README - Add description about the new feature Signed-off-by: Uilian Ries <uilianries@gmail.com> * #237 Upload all dependencies Signed-off-by: Uilian Ries <uilianries@gmail.com> * #237 Unit test to upload all deps Signed-off-by: Uilian Ries <uilianries@gmail.com> * #237 Fix env var name Signed-off-by: Uilian Ries <uilianries@gmail.com> * #237 Fix upload dependencies Signed-off-by: Uilian Ries <uilianries@gmail.com> * #237 Upload only built packages Signed-off-by: Uilian Ries <uilianries@gmail.com> * #237 Only upload when package is available Signed-off-by: Uilian Ries <uilianries@gmail.com> * Accept custom pip command (#347) * #147 Support custom PIP command - Add env var CONAN_PIP_COMMAND which allows to run a specific pip version, or even a pip binary path. Signed-off-by: Uilian Ries <uilianries@gmail.com> * #147 Check pip command before to run - To avoid command injection, the custom pip command will be checked Signed-off-by: Uilian Ries <uilianries@gmail.com> * #147 Test dynamic pip version - Check for current pip version before to customize CONAN_PIP_COMMAND Signed-off-by: Uilian Ries <uilianries@gmail.com> * #147 Ignore which pip on Windows Signed-off-by: Uilian Ries <uilianries@gmail.com> * #147 pip install quiet mode Signed-off-by: Uilian Ries <uilianries@gmail.com> * #147 Try to fix Windows tests Signed-off-by: Uilian Ries <uilianries@gmail.com> * #277 Accept Docker arguments as list - both string and list are accepted as docker arguments - Update docker test to use list Signed-off-by: Uilian Ries <uilianries@gmail.com> * #277 Fix options when downloading docker image - Docker is executed in two cases. The first one is when we need to download the docker image and patch with the newest Conan version. The options were skipped there Signed-off-by: Uilian Ries <uilianries@gmail.com> * #354 Add CONAN_CONANFILE option (#357) * #354 Add CONAN_CONANFILE option Signed-off-by: Uilian Ries <uilianries@gmail.com> * #354 Add option description on README Signed-off-by: Uilian Ries <uilianries@gmail.com> * #354 Support CONAN_CONANFILE option - Add full support for custom conanfile name - Add tests Signed-off-by: Uilian Ries <uilianries@gmail.com> * #354 Fix boolean option Signed-off-by: Uilian Ries <uilianries@gmail.com> * #355 Skip check credentials is boolean (#356) - Parse the env var CONAN_SKIP_CHECK_CREDENTIALS as boolean Signed-off-by: Uilian Ries <uilianries@gmail.com> * fix azure pipelines branch detection (#346) use variable BUILD_SOURCEBRANCH BUILD_SOURCEBRANCHNAME only has the part after last / * Feature/upload only recipe (#348) * #153 Upload only the recipe - Add CONAN_UPLOAD_ONLY_RECIPE env var, which set to skip all binary packages upload. Signed-off-by: Uilian Ries <uilianries@gmail.com> * #153 Test upload only the recipe - get boolean value from environment variable is non-case sensitive now Signed-off-by: Uilian Ries <uilianries@gmail.com> * #153 Fix upload recipe argument @madebr found a bug where the argument is wrong. Co-Authored-By: uilianries <uilianries@gmail.com> * #153 Fix unit test for upload recipe Signed-off-by: Uilian Ries <uilianries@gmail.com> * #153 Add test to check parameters Signed-off-by: Uilian Ries <uilianries@gmail.com> * #153 Fix conflict in README file * Update Docker run example - Use custom Docker network instead of using custom cache. Signed-off-by: Uilian Ries <uilianries@gmail.com> * Prepared for 1.15 * 0.25.0 * 1.15.0 * Fix Tox version (#364) - Tox 3.8.1 is totally broken Signed-off-by: Uilian Ries <uilianries@gmail.com> * #361 Upload package with revisions (#363) * #361 Upload package with revisions - Package reference passed to be created is not the same retrieved from package id when the package is built. "foo/0.1@bar/testing" != "foo/0.1@bar/testing#<hash>" Signed-off-by: Uilian Ries <uilianries@gmail.com> * #361 Parse revision Signed-off-by: Uilian Ries <uilianries@gmail.com> * Fix broken tests for release 0.25.0 (#365) * Fix broken tests for release 0.25.0 - Release branch is fragile, only specific tests are able to run, or even CPT behavior could change during the tests. Signed-off-by: Uilian Ries <uilianries@gmail.com> * Run Docker test as regular test - Do not require Bintray account to run docker tests Signed-off-by: Uilian Ries <uilianries@gmail.com> * Clean some stuff and improve test running in local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Fix Azure DevOps branch name (#346)
use variable BUILD_SOURCEBRANCH
BUILD_SOURCEBRANCHNAME only has the part after last /