-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass cwd to DockerCreateRunner, #447 #528
Conversation
Seems like master should be merged to develop with 1.30 upgrade |
I hit this issue too and fixed it in the same way Croydon@7c0a455 I definitely should have searched here before 😄 @uilianries could you please have a look? |
Unfortunately, the same:
|
I think you have to do a |
Rebased but support for 1.31.0 (#530) is not merged yet. |
Somewhat weird that CPT is using a testing suite for versions it doesn't yet support Anyhow, I guess now you can re-base and it should work? |
Almost! Now one of builds complaints with "Exception: Conan/CPT version mismatch. Conan version installed: 1.32.0 . This version of CPT supports only Conan < 1.31" :( |
I don't understand the CI setup and the error has clearly nothing to do with this pull request @uilianries How do we move this forward? |
@Croydon tried but the build fails again. Probably it is conan==1.32.0.dev0 vs 1.32.0 |
We can switch to stable as soon as conan-io/conan-package-tools#528 is merged
Requires #531 |
The patch allows building packages using Docker in non-flat repositories with specifying cwd. Example: builder = ConanMultiPackager(cwd=os.path.join(os.getcwd(), 'recipes', 'foobar'))
PR #531 has been merged. Let's see the next result for this PR. |
Success! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you all! |
Fixes PR #447
The patch allows building packages using Docker in non-flat repositories
with specifying cwd.
Example:
Changelog: Feature: Pass cwd to DockerCreateRunner