Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass cwd to DockerCreateRunner, #447 #528

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Conversation

theirix
Copy link
Contributor

@theirix theirix commented Oct 21, 2020

Fixes PR #447

The patch allows building packages using Docker in non-flat repositories
with specifying cwd.

Example:

builder = ConanMultiPackager(cwd=os.path.join(os.getcwd(), 'recipes', 'foobar'))

Changelog: Feature: Pass cwd to DockerCreateRunner

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.

@theirix
Copy link
Contributor Author

theirix commented Oct 21, 2020

Seems like master should be merged to develop with 1.30 upgrade

@Croydon
Copy link
Contributor

Croydon commented Oct 27, 2020

I hit this issue too and fixed it in the same way Croydon@7c0a455

I definitely should have searched here before 😄

@uilianries could you please have a look?

@uilianries uilianries closed this Oct 30, 2020
@uilianries uilianries reopened this Oct 30, 2020
@theirix
Copy link
Contributor Author

theirix commented Oct 31, 2020

Unfortunately, the same:

Exception: Conan/CPT version mismatch. Conan version installed: 1.31.0 . 
This version of CPT supports only Conan < 1.30

@Croydon
Copy link
Contributor

Croydon commented Oct 31, 2020

I think you have to do a git fetch upstream && git rebase upstream/develop

@theirix
Copy link
Contributor Author

theirix commented Oct 31, 2020

I think you have to do a git fetch upstream && git rebase upstream/develop

Rebased but support for 1.31.0 (#530) is not merged yet.

@Croydon
Copy link
Contributor

Croydon commented Nov 1, 2020

Somewhat weird that CPT is using a testing suite for versions it doesn't yet support

Anyhow, I guess now you can re-base and it should work?

@theirix
Copy link
Contributor Author

theirix commented Nov 1, 2020

Somewhat weird that CPT is using a testing suite for versions it doesn't yet support

Anyhow, I guess now you can re-base and it should work?

Almost! Now one of builds complaints with "Exception: Conan/CPT version mismatch. Conan version installed: 1.32.0 . This version of CPT supports only Conan < 1.31" :(

@Croydon
Copy link
Contributor

Croydon commented Nov 2, 2020

I don't understand the CI setup and the error has clearly nothing to do with this pull request

@uilianries How do we move this forward?

@Croydon
Copy link
Contributor

Croydon commented Nov 5, 2020

@theirix Could you update the value of NEWEST_CONAN_SUPPORTED and the version in requirements.txt for Conan 1.32.0?

The current develop branch fails too because of this

245b721

@theirix
Copy link
Contributor Author

theirix commented Nov 6, 2020

@Croydon tried but the build fails again. Probably it is conan==1.32.0.dev0 vs 1.32.0

Croydon added a commit to bincrafters/conan-qt that referenced this pull request Nov 9, 2020
We can switch to stable as soon as conan-io/conan-package-tools#528 is merged
@Croydon
Copy link
Contributor

Croydon commented Nov 12, 2020

Requires #531

The patch allows building packages using Docker in non-flat repositories
with specifying cwd.

Example:

    builder = ConanMultiPackager(cwd=os.path.join(os.getcwd(), 'recipes', 'foobar'))
@uilianries
Copy link
Member

uilianries commented Nov 17, 2020

PR #531 has been merged. Let's see the next result for this PR.

@Croydon
Copy link
Contributor

Croydon commented Nov 18, 2020

Success! 🎉

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uilianries uilianries merged commit b6d6816 into conan-io:develop Nov 18, 2020
@uilianries
Copy link
Member

Thank you all!

@uilianries uilianries mentioned this pull request Dec 3, 2020
Croydon added a commit to bincrafters/bincrafters-package-tools that referenced this pull request Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants