-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide sensitive information from getting displayed/logged. #536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just copied the fix from an old source file and forgot to change the function arguments.
cpt/runner.py
Outdated
@@ -376,7 +377,11 @@ def __init__(self, runner, printer): | |||
self.printer = printer | |||
|
|||
def __call__(self, command): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opps..! Need to add "hide_sensitive=True" for the arguments.
It looks great. Is it possible add a test to check this new output? |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Depends on conan-io/conan#8132 |
Depends on #538 |
Codecov Report
@@ Coverage Diff @@
## develop #536 +/- ##
===========================================
+ Coverage 79.13% 79.21% +0.08%
===========================================
Files 41 41
Lines 4917 4932 +15
===========================================
+ Hits 3891 3907 +16
+ Misses 1026 1025 -1
Continue to review full report at Codecov.
|
Changelog: Fix: Fixes the issue with sensitive details are exposed in build log files
fixes #535