-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] expose CMakeToolchain conf to be able to set CMAKE_GENERATOR_INSTANCE #16222
Closed
1 task
Milestone
Comments
I have been reviewing #16229, but then I had recall that we had discussed this policy before:
I have rejected feature requests from users very similar to this one. |
perseoGI
added a commit
that referenced
this issue
May 13, 2024
5 tasks
perseoGI
added a commit
that referenced
this issue
May 13, 2024
perseoGI
added a commit
that referenced
this issue
May 21, 2024
AbrilRBS
pushed a commit
to AbrilRBS/conan
that referenced
this issue
May 21, 2024
AbrilRBS
pushed a commit
to AbrilRBS/conan
that referenced
this issue
May 21, 2024
perseoGI
added a commit
that referenced
this issue
May 29, 2024
memsharded
pushed a commit
that referenced
this issue
Jun 3, 2024
* Added support for tools.cmake.cmaketoolchain:extra_variables (#16222) * Moved extra_variable from GenericSystemBlock to new block which will be executed later * Moved extra variables just before the try_compile block. This will allow users to re-define variables * Added extra parse layout for cmaketoolchain:extra_variables Now it admits not only plain key:value pairs but dictionary values in the form: {'value': <value>, 'cache': <true/false>, 'type': <cache_type>, 'docstring': <cache docstring> } * Fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is your suggestion?
When the CMake generator is a Visual Studio one, for example
Visual Studio 17 2022
(see docs https://cmake.org/cmake/help/latest/manual/cmake-generators.7.html#visual-studio-generators), there are systems in which there are multiple instances of Visual Studio 2022 installed, for example:When not specified, CMake decides, as per documentation:
Each installation of Visual Studio can have different toolsets installed:
So we could end up with scenarios where the Conan profiles specify settings that can only be satisfied by one particular instance of Visual Studio, but then CMake doesn't choose that instance by default.
Proposed solution:
tools.cmake.cmaketoolchain:generator_instance
, such that if defined,conan_toolchain.cmake
will contain an entry settingCMAKE_GENERATOR_INSTANCE
with the value provided by the userHave you read the CONTRIBUTING guide?
The text was updated successfully, but these errors were encountered: