-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qbs: Added qbs test lib api and fixed handling spaces #16382
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
from conan.internal.api.new.cmake_lib import source_cpp, source_h | ||
|
||
|
||
conanfile_sources = ''' | ||
import os | ||
|
||
from conan import ConanFile, tools | ||
from conan.tools.qbs import Qbs | ||
from conan.tools.files import copy, collect_libs | ||
|
||
class {{package_name}}Recipe(ConanFile): | ||
name = "{{name}}" | ||
version = "{{version}}" | ||
|
||
exports_sources = "*.cpp", "*.h", "*.qbs" | ||
settings = "os", "compiler", "arch" | ||
|
||
def build(self): | ||
qbs = Qbs(self) | ||
qbs.profile = "" | ||
qbs.build() | ||
|
||
def package(self): | ||
qbs = Qbs(self) | ||
qbs.profile = "" | ||
qbs.install() | ||
|
||
def package_info(self): | ||
self.cpp_info.libs = collect_libs(self) | ||
ABBAPOH marked this conversation as resolved.
Show resolved
Hide resolved
|
||
''' | ||
|
||
qbs_file = ''' | ||
Library { | ||
type: "staticlibrary" | ||
ABBAPOH marked this conversation as resolved.
Show resolved
Hide resolved
|
||
files: [ "{{name}}.h", "{{name}}.cpp" ] | ||
Depends { name: "cpp" } | ||
Depends { name: "bundle" } | ||
bundle.isBundle: false | ||
install: true | ||
} | ||
''' | ||
|
||
qbs_lib_files = {"conanfile.py": conanfile_sources, | ||
"{{name}}.qbs": qbs_file, | ||
"{{name}}.cpp": source_cpp, | ||
"{{name}}.h": source_h} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import pytest | ||
|
||
from conan.internal.api.new.cmake_lib import source_cpp, source_h | ||
from conan.internal.api.new.qbs_lib import qbs_file, conanfile_sources | ||
from conan.test.utils.tools import TestClient | ||
from jinja2 import Template | ||
|
||
|
||
def gen_file(template, **context): | ||
t = Template(template) | ||
return t.render(**context) | ||
|
||
|
||
@pytest.mark.tool("qbs") | ||
def test_qbs_static_lib(): | ||
ABBAPOH marked this conversation as resolved.
Show resolved
Hide resolved
|
||
client = TestClient() | ||
|
||
context = { | ||
"name": "hello", | ||
"version": "2.0", | ||
"package_name": "hello" | ||
} | ||
|
||
client.save({ | ||
"conanfile.py": gen_file(conanfile_sources, **context), | ||
"hello.cpp": gen_file(source_cpp, **context), | ||
"hello.h": gen_file(source_h, **context), | ||
"hello.qbs": gen_file(qbs_file, **context), | ||
}, clean_first=True) | ||
|
||
client.run("create .") | ||
assert "compiling hello.cpp" in client.out | ||
|
||
|
||
@pytest.mark.tool("qbs") | ||
def test_api_qbs_create_lib(): | ||
client = TestClient() | ||
client.run("new qbs_lib -d name=hello -d version=1.0") | ||
client.run("create .") | ||
assert "compiling hello.cpp" in client.out |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have a qbs template 👍