Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qbs: pass provider args if QbsDeps was run #16486

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

ABBAPOH
Copy link
Contributor

@ABBAPOH ABBAPOH commented Jun 16, 2024

Changelog: Feature: Qbs helper now invokes Conan provider automatically.
Docs: Omit

Now Qbs helper passes required arguments for the "conan" provider to qbs if QbsDeps was run.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@ABBAPOH ABBAPOH changed the title Qbs: pass provider args if QbsDeps were run Qbs: pass provider args if QbsDeps was run Jun 16, 2024
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor naming issue: When we talk about "Qbs Toolchainit should be aQbsToolchainspecific generator that is intended to generate files related to the current settings and options (not dependencies likeQbsDeps). The Qbs`` is not called a toolchain generator is typically called the "Qbs" helper or wrapper.

conan/tools/qbs/qbs.py Outdated Show resolved Hide resolved
@memsharded memsharded merged commit 4d8ccbd into conan-io:develop2 Jun 18, 2024
2 checks passed
@memsharded memsharded added this to the 2.5.0 milestone Jun 18, 2024
@ABBAPOH ABBAPOH deleted the qbs-deps-resolve branch July 24, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants