Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight missing or invalid requirements while computing dependency … #16520

Merged

Conversation

perseoGI
Copy link
Contributor

@perseoGI perseoGI commented Jun 21, 2024

Changelog: Feature: Highlight missing or invalid requirements while computing dependency graph.
Docs: omit

Close #16390

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@perseoGI perseoGI added this to the 2.5.0 milestone Jun 21, 2024
@perseoGI perseoGI requested a review from memsharded June 21, 2024 12:18
@AbrilRBS AbrilRBS self-requested a review June 21, 2024 12:43
@perseoGI perseoGI force-pushed the 16390-highlight-bad-requirements branch from 9cac2aa to e476e71 Compare June 21, 2024 12:44
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colourblind approved 👍

image

For this, I might think that the information bit be a bit too repeated? Not something bothersome, just wanted to note it

image

@perseoGI perseoGI force-pushed the 16390-highlight-bad-requirements branch from e476e71 to e6d8683 Compare June 21, 2024 13:02
@perseoGI
Copy link
Contributor Author

For this, I might think that the information bit be a bit too repeated? Not something bothersome, just wanted to note it

Yayaya, definitely we may consider changing a little bit the error output.
Having colorful output is useful but some users may not use terminals supporting colorized outputs, CIs, plugins, etc.

What do you suggest @RubenRBS ?

@AbrilRBS
Copy link
Member

What do you suggest @RubenRBS ?

Let's think about it offline tomorrow :)

@AbrilRBS AbrilRBS self-assigned this Jun 24, 2024
@AbrilRBS AbrilRBS merged commit 3782127 into conan-io:develop2 Jun 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Highlight requirements when they are invalid or missing
3 participants