-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add html output for graph build-order and graph build-order-merge #16611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a pity that we couldnt do this with the other js library, and use the same node formatters. If possible I'd try to use tool-requires and test-requires with a different shape, but not a big issue.
Also the alignment of the layers, but I guess that you have already tried and it is far from easy, so not an issue either.
Good to go!
Yes, it looks like vis.js is not the right library for this kind of diagrams... 🫤 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments, otherwise looks good
Changelog: Feature: Add html output for graph build-order and graph build-order-merge
Docs: conan-io/docs#3805
Closes: #16356