Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html output for graph build-order and graph build-order-merge #16611

Merged
merged 13 commits into from
Jul 5, 2024

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Jul 4, 2024

Changelog: Feature: Add html output for graph build-order and graph build-order-merge
Docs: conan-io/docs#3805

Closes: #16356

image

@czoido czoido added this to the 2.6.0 milestone Jul 4, 2024
@czoido czoido requested a review from AbrilRBS July 4, 2024 12:24
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a pity that we couldnt do this with the other js library, and use the same node formatters. If possible I'd try to use tool-requires and test-requires with a different shape, but not a big issue.
Also the alignment of the layers, but I guess that you have already tried and it is far from easy, so not an issue either.

Good to go!

@czoido
Copy link
Contributor Author

czoido commented Jul 4, 2024

I think it is a pity that we couldnt do this with the other js library, and use the same node formatters. If possible I'd try to use tool-requires and test-requires with a different shape, but not a big issue. Also the alignment of the layers, but I guess that you have already tried and it is far from easy, so not an issue either.

Good to go!

Yes, it looks like vis.js is not the right library for this kind of diagrams... 🫤
I have updated the output to show the requires from the build context a bit different.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments, otherwise looks good

conan/cli/formatters/graph/build_order_html.py Outdated Show resolved Hide resolved
conan/cli/formatters/graph/build_order_html.py Outdated Show resolved Hide resolved
@czoido czoido merged commit b0d916f into conan-io:develop2 Jul 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] html graph from existing build-order.json
3 participants