-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add finalize()
method to ConanFile
#16646
Conversation
--------- Co-authored-by: PerseoGI <perseog@jfrog.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very good, good job :)
I am very happy to see that apparently the new cache design, architecture, folders, etc, seem to support this use case in a way that looks like one order of magnitude more doable than in Conan 1.
Co-authored-by: PerseoGI <perseog@jfrog.com>
Co-authored-by: PerseoGI <perseog@jfrog.com>
Co-authored-by: PerseoGI <perseog@jfrog.com>
Co-authored-by: PerseoGI <perseog@jfrog.com>
Co-authored-by: PerseoGI <perseog@jfrog.com>
Co-authored-by: PerseoGI <perseog@jfrog.com>
install()
method to ConanFilelocalize()
method to ConanFile
localize()
method to ConanFilefinalize()
method to ConanFile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not super convinced about the name of the feature. Not that these are better but leaving some more options here:
customize()
modify()
prepare()
adjust()
mute()
tweak()
We have already considered all of them with @AbrilRBS (we spent some hours thinking about this 😅 ) except the last 2 |
yes, sorry, I meant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it is the best name, I hope users won't mix post-hook
concept with this new method.
LGTM 🚀
Changelog: Feature: Add
finalize()
method for local cache final adjustments of packages.Docs: conan-io/docs#3820
We'll want to release a blogpost alongside the feature
Closes #15277
Closes #16707